All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: David Vrabel <david.vrabel@csr.com>
Cc: Ben Dooks <ben@fluff.org>,
	sdhci-devel@lists.ossman.eu, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Pierre Ossman <pierre@ossman.eu>
Subject: Re: [PATCH 3/4] sdhci-of: Fix high-speed cards recognition
Date: Fri, 7 Aug 2009 22:43:19 +0400	[thread overview]
Message-ID: <20090807184319.GA22652@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4A7C5FAB.2020304@csr.com>

On Fri, Aug 07, 2009 at 06:08:59PM +0100, David Vrabel wrote:
> Anton Vorontsov wrote:
> > eSDHC fails to recognize some SDHS cards, throwing timeout errors:
> > 
> >   mmc0: error -110 whilst initialising SD card
> > 
> > That's because we calculate timeout value in a wrong way: on eSDHC
> > hosts the timeout clock is derivied from the SD clock, which is set
> > dynamically.
> 
> I've seen an reference design for an SDHC controller do this also.

Thanks for the information!

> > +/* Controller has dynamic timeout clock management */
> > +#define SDHCI_QUIRK_DYNAMIC_TIMEOUT_CLOCK		(1<<24)
> 
> This comment and define would be better if it matched terms used in the
> spec.  Suggest:
> 
> /* Controller uses SDCLK instead of TMCLK for data timeouts. */
> #define SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK  (1 << 24)

Yeah, if it's somewhat common scheme, then it makes sense to name the
quirk that way.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: David Vrabel <david.vrabel@csr.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Pierre Ossman <pierre@ossman.eu>,
	Kumar Gala <galak@kernel.crashing.org>, Ben Dooks <ben@fluff.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org, sdhci-devel@lists.ossman.eu,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/4] sdhci-of: Fix high-speed cards recognition
Date: Fri, 7 Aug 2009 22:43:19 +0400	[thread overview]
Message-ID: <20090807184319.GA22652@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4A7C5FAB.2020304@csr.com>

On Fri, Aug 07, 2009 at 06:08:59PM +0100, David Vrabel wrote:
> Anton Vorontsov wrote:
> > eSDHC fails to recognize some SDHS cards, throwing timeout errors:
> > 
> >   mmc0: error -110 whilst initialising SD card
> > 
> > That's because we calculate timeout value in a wrong way: on eSDHC
> > hosts the timeout clock is derivied from the SD clock, which is set
> > dynamically.
> 
> I've seen an reference design for an SDHC controller do this also.

Thanks for the information!

> > +/* Controller has dynamic timeout clock management */
> > +#define SDHCI_QUIRK_DYNAMIC_TIMEOUT_CLOCK		(1<<24)
> 
> This comment and define would be better if it matched terms used in the
> spec.  Suggest:
> 
> /* Controller uses SDCLK instead of TMCLK for data timeouts. */
> #define SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK  (1 << 24)

Yeah, if it's somewhat common scheme, then it makes sense to name the
quirk that way.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2009-08-07 18:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-07 16:39 [PATCH 0/4] sdhci-of: Some fixes for high-speed and 4-bit SD cards Anton Vorontsov
2009-08-07 16:39 ` Anton Vorontsov
2009-08-07 16:40 ` [PATCH 1/4] sdhci-of: Fix SD clock calculation Anton Vorontsov
2009-08-07 16:40   ` Anton Vorontsov
2009-08-07 16:49 ` [PATCH 2/4] sdhci-of: Avoid writing reserved bits into host control register Anton Vorontsov
2009-08-07 16:49   ` Anton Vorontsov
2009-08-07 16:50 ` [PATCH 3/4] sdhci-of: Fix high-speed cards recognition Anton Vorontsov
2009-08-07 16:50   ` Anton Vorontsov
2009-08-07 17:08   ` David Vrabel
2009-08-07 17:08     ` David Vrabel
2009-08-07 18:43     ` Anton Vorontsov [this message]
2009-08-07 18:43       ` Anton Vorontsov
2009-08-07 16:50 ` [PATCH 4/4] sdhci-of: Cleanup eSDHC's set_clock() a little bit Anton Vorontsov
2009-08-07 16:50   ` Anton Vorontsov
2009-08-07 18:41 ` [PATCH 0/4] sdhci-of: Some fixes for high-speed and 4-bit SD cards Anton Vorontsov
2009-08-07 18:41   ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090807184319.GA22652@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=akpm@linux-foundation.org \
    --cc=ben@fluff.org \
    --cc=david.vrabel@csr.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=pierre@ossman.eu \
    --cc=sdhci-devel@lists.ossman.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.