All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@xensource.com>
Subject: [PATCH] xen: xen_init_cpuid_mask: Zero cx before calling xen_cpuid
Date: Sat, 8 Aug 2009 13:15:00 -0700	[thread overview]
Message-ID: <20090808201500.GA21828@feather> (raw)

CPUID function 1 doesn't use cx, but xen_cpuid doesn't know that,
resulting in this warning:

arch/x86/xen/enlighten.c: In function ‘xen_start_kernel’:
arch/x86/xen/enlighten.c:192: warning: ‘cx’ may be used uninitialized in this function
arch/x86/xen/enlighten.c:205: note: ‘cx’ was declared here

Set cx = 0 to avoid this warning.  This seems preferable to implementing
a xen_cpuid_nocount without the input constraint for cx, and either of
those seem preferable to just ignoring the warning.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---

Build-tested only.

 arch/x86/xen/enlighten.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 0a1700a..6ee2ef8 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -215,6 +215,7 @@ static __init void xen_init_cpuid_mask(void)
 			  (1 << X86_FEATURE_ACPI));  /* disable ACPI */
 
 	ax = 1;
+	cx = 0;
 	xen_cpuid(&ax, &bx, &cx, &dx);
 
 	/* cpuid claims we support xsave; try enabling it to see what happens */
-- 
1.5.6.5


             reply	other threads:[~2009-08-08 20:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-08 20:15 Josh Triplett [this message]
2009-08-15  7:02 ` [PATCH] xen: xen_init_cpuid_mask: Zero cx before calling xen_cpuid Jeremy Fitzhardinge
2009-08-15  7:02   ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090808201500.GA21828@feather \
    --to=josh@joshtriplett.org \
    --cc=akpm@linux-foundation.org \
    --cc=jeremy@xensource.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.