All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@xensource.com>
Subject: Re: [PATCH] xen: xen_init_cpuid_mask: Zero cx before calling xen_cpuid
Date: Sat, 15 Aug 2009 00:02:30 -0700	[thread overview]
Message-ID: <4A865D86.2050002@goop.org> (raw)
In-Reply-To: <20090808201500.GA21828@feather>

On 08/08/09 13:15, Josh Triplett wrote:
> CPUID function 1 doesn't use cx, but xen_cpuid doesn't know that,
> resulting in this warning:
>
> arch/x86/xen/enlighten.c: In function ‘xen_start_kernel’:
> arch/x86/xen/enlighten.c:192: warning: ‘cx’ may be used uninitialized in this function
> arch/x86/xen/enlighten.c:205: note: ‘cx’ was declared here
>
> Set cx = 0 to avoid this warning.  This seems preferable to implementing
> a xen_cpuid_nocount without the input constraint for cx, and either of
> those seem preferable to just ignoring the warning.
>   

Thanks, applied.

    J

WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
	Jeremy Fitzhardinge <jeremy@xensource.com>
Subject: Re: [PATCH] xen: xen_init_cpuid_mask: Zero cx before calling xen_cpuid
Date: Sat, 15 Aug 2009 00:02:30 -0700	[thread overview]
Message-ID: <4A865D86.2050002@goop.org> (raw)
In-Reply-To: <20090808201500.GA21828@feather>

On 08/08/09 13:15, Josh Triplett wrote:
> CPUID function 1 doesn't use cx, but xen_cpuid doesn't know that,
> resulting in this warning:
>
> arch/x86/xen/enlighten.c: In function ‘xen_start_kernel’:
> arch/x86/xen/enlighten.c:192: warning: ‘cx’ may be used uninitialized in this function
> arch/x86/xen/enlighten.c:205: note: ‘cx’ was declared here
>
> Set cx = 0 to avoid this warning.  This seems preferable to implementing
> a xen_cpuid_nocount without the input constraint for cx, and either of
> those seem preferable to just ignoring the warning.
>   

Thanks, applied.

    J

  reply	other threads:[~2009-08-15  7:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-08 20:15 [PATCH] xen: xen_init_cpuid_mask: Zero cx before calling xen_cpuid Josh Triplett
2009-08-15  7:02 ` Jeremy Fitzhardinge [this message]
2009-08-15  7:02   ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A865D86.2050002@goop.org \
    --to=jeremy@goop.org \
    --cc=akpm@linux-foundation.org \
    --cc=jeremy@xensource.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.