[Qemu-devel] RE: 971c47c - Do not use $SHELL to invoke our scripts

[Qemu-devel] RE: 971c47c - Do not use $SHELL to invoke our scripts

[Jordan Justen]

Regarding commit 971c47c, this causes a build error for me on Ubuntu
9.04.  I think this might be because Ubuntu/Debian have moved /bin/sh
from bash to dash.  The build is okay if I change the first line of
configure from /bin/sh to /bin/bash.  Should configure point directly
at bash?

-Jordan

Re: [Qemu-devel] RE: 971c47c - Do not use $SHELL to invoke our scripts

[Brad]

On Wednesday 12 August 2009 21:01:52 Jordan Justen wrote:
> Regarding commit 971c47c, this causes a build error for me on Ubuntu
> 9.04.  I think this might be because Ubuntu/Debian have moved /bin/sh
> from bash to dash.  The build is okay if I change the first line of
> configure from /bin/sh to /bin/bash.  Should configure point directly
> at bash?
>
> -Jordan

Not unless your goal is to break building on every other OS out there.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] RE: 971c47c - Do not use $SHELL to invoke our scripts

[Jordan Justen]

On Wed, Aug 12, 2009 at 6:09 PM, Brad<brad@comstyle.com> wrote:
> On Wednesday 12 August 2009 21:01:52 Jordan Justen wrote:
>> Regarding commit 971c47c, this causes a build error for me on Ubuntu
>> 9.04.  I think this might be because Ubuntu/Debian have moved /bin/sh
>> from bash to dash.  The build is okay if I change the first line of
>> configure from /bin/sh to /bin/bash.  Should configure point directly
>> at bash?
>>
>> -Jordan
>
> Not unless your goal is to break building on every other OS out there.

So, this is an issue of dash being an inadequate /bin/sh rather than
configure being dependent on bash?

>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>

Re: [Qemu-devel] RE: 971c47c - Do not use $SHELL to invoke our scripts

[Brad]

On Wednesday 12 August 2009 21:15:25 Jordan Justen wrote:
> On Wed, Aug 12, 2009 at 6:09 PM, Brad<brad@comstyle.com> wrote:
> > On Wednesday 12 August 2009 21:01:52 Jordan Justen wrote:
> >> Regarding commit 971c47c, this causes a build error for me on Ubuntu
> >> 9.04.  I think this might be because Ubuntu/Debian have moved /bin/sh
> >> from bash to dash.  The build is okay if I change the first line of
> >> configure from /bin/sh to /bin/bash.  Should configure point directly
> >> at bash?
> >>
> >> -Jordan
> >
> > Not unless your goal is to break building on every other OS out there.
>
> So, this is an issue of dash being an inadequate /bin/sh rather than
> configure being dependent on bash?

I cannot comment about dash but configure does not need bash.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] RE: 971c47c - Do not use $SHELL to invoke our scripts

[malc]

On Wed, 12 Aug 2009, Jordan Justen wrote:

> Regarding commit 971c47c, this causes a build error for me on Ubuntu
> 9.04.  I think this might be because Ubuntu/Debian have moved /bin/sh
> from bash to dash.  The build is okay if I change the first line of
> configure from /bin/sh to /bin/bash.  Should configure point directly
> at bash?

Please be more specific, what is the error? And FWIW i mainly use ash
to run QEMUs configure (and dash is derived from ash as far as i can
tell)

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] RE: 971c47c - Do not use $SHELL to invoke our scripts

[Jordan Justen]

On Wed, Aug 12, 2009 at 7:03 PM, malc<av1474@comtv.ru> wrote:
> On Wed, 12 Aug 2009, Jordan Justen wrote:
>
>> Regarding commit 971c47c, this causes a build error for me on Ubuntu
>> 9.04.  I think this might be because Ubuntu/Debian have moved /bin/sh
>> from bash to dash.  The build is okay if I change the first line of
>> configure from /bin/sh to /bin/bash.  Should configure point directly
>> at bash?
>
> Please be more specific, what is the error? And FWIW i mainly use ash
> to run QEMUs configure (and dash is derived from ash as far as i can
> tell)

It seems to only be an issue with dash if I run it as './configure'.
'dash configure' is okay.

With /bin/sh -> bash, if I insert an 'echo $_' before this line in configure:
THISSHELL=${_:-/bin/sh}
then $_ is blank.

With /bin/sh -> dash, 'echo $_' just before that line will show $_ to
be './configure'.  Therefore THISSHELL becomes './configure', which is
obviously invalid.

I'm not sure of a fix yet...

>
> --
> mailto:av1474@comtv.ru
>

Re: [Qemu-devel] RE: 971c47c - Do not use $SHELL to invoke our scripts

[malc]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1213 bytes --]

On Wed, 12 Aug 2009, Jordan Justen wrote:

> On Wed, Aug 12, 2009 at 7:03 PM, malc<av1474@comtv.ru> wrote:
> > On Wed, 12 Aug 2009, Jordan Justen wrote:
> >
> >> Regarding commit 971c47c, this causes a build error for me on Ubuntu
> >> 9.04.  I think this might be because Ubuntu/Debian have moved /bin/sh
> >> from bash to dash.  The build is okay if I change the first line of
> >> configure from /bin/sh to /bin/bash.  Should configure point directly
> >> at bash?
> >
> > Please be more specific, what is the error? And FWIW i mainly use ash
> > to run QEMUs configure (and dash is derived from ash as far as i can
> > tell)
> 
> It seems to only be an issue with dash if I run it as './configure'.
> 'dash configure' is okay.
> 
> With /bin/sh -> bash, if I insert an 'echo $_' before this line in configure:
> THISSHELL=${_:-/bin/sh}
> then $_ is blank.
> 
> With /bin/sh -> dash, 'echo $_' just before that line will show $_ to
> be './configure'.  Therefore THISSHELL becomes './configure', which is
> obviously invalid.
> 
> I'm not sure of a fix yet...

Thanks for analysis, i've pushed the "fix" hopefully it would finally put
an end to this.

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] RE: 971c47c - Do not use $SHELL to invoke our scripts

[Jordan Justen]

2009/8/12 malc <av1474@comtv.ru>:
> On Wed, 12 Aug 2009, Jordan Justen wrote:
>
>> On Wed, Aug 12, 2009 at 7:03 PM, malc<av1474@comtv.ru> wrote:
>> > On Wed, 12 Aug 2009, Jordan Justen wrote:
>> >
>> >> Regarding commit 971c47c, this causes a build error for me on Ubuntu
>> >> 9.04.  I think this might be because Ubuntu/Debian have moved /bin/sh
>> >> from bash to dash.  The build is okay if I change the first line of
>> >> configure from /bin/sh to /bin/bash.  Should configure point directly
>> >> at bash?
>> >
>> > Please be more specific, what is the error? And FWIW i mainly use ash
>> > to run QEMUs configure (and dash is derived from ash as far as i can
>> > tell)
>>
>> It seems to only be an issue with dash if I run it as './configure'.
>> 'dash configure' is okay.
>>
>> With /bin/sh -> bash, if I insert an 'echo $_' before this line in configure:
>> THISSHELL=${_:-/bin/sh}
>> then $_ is blank.
>>
>> With /bin/sh -> dash, 'echo $_' just before that line will show $_ to
>> be './configure'.  Therefore THISSHELL becomes './configure', which is
>> obviously invalid.
>>
>> I'm not sure of a fix yet...
>
> Thanks for analysis, i've pushed the "fix" hopefully it would finally put
> an end to this.

Your new version works well for me.  Thanks.

>
> --
> mailto:av1474@comtv.ru