From: Ben Dooks <ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
dbrownell-Rn4VEauK+AKRv+LV9MX5uv+2+P5yyue3@public.gmane.org
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [patch 4/7] spi_s3c24xx: fix header includes
Date: Thu, 13 Aug 2009 11:06:06 +0100 [thread overview]
Message-ID: <20090813100638.799449205@fluff.org> (raw)
In-Reply-To: 20090813100602.545180197@fluff.org
[-- Attachment #1: spi-fix-includes.patch --]
[-- Type: text/plain, Size: 1248 bytes --]
The driver includes <asm/io.h> where it should be including <linux/io.h>
and also includes <mach/hardware.h> and <asm/dma.h> without using anything
from these.
Signed-off-by; Ben Dooks <ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>
---
drivers/spi/spi_s3c24xx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Index: b/drivers/spi/spi_s3c24xx.c
===================================================================
--- a/drivers/spi/spi_s3c24xx.c 2009-07-28 15:19:28.000000000 +0100
+++ b/drivers/spi/spi_s3c24xx.c 2009-07-28 15:20:16.000000000 +0100
@@ -20,14 +20,11 @@
#include <linux/clk.h>
#include <linux/platform_device.h>
#include <linux/gpio.h>
+#include <linux/io.h>
#include <linux/spi/spi.h>
#include <linux/spi/spi_bitbang.h>
-#include <asm/io.h>
-#include <asm/dma.h>
-#include <mach/hardware.h>
-
#include <plat/regs-spi.h>
#include <mach/spi.h>
--
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben@simtec.co.uk>
To: spi-devel-general@lists.sourceforge.net, dbrownell@users.sourceforge.ne
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [patch 4/7] spi_s3c24xx: fix header includes
Date: Thu, 13 Aug 2009 11:06:06 +0100 [thread overview]
Message-ID: <20090813100638.799449205@fluff.org> (raw)
In-Reply-To: 20090813100602.545180197@fluff.org
[-- Attachment #1: spi-fix-includes.patch --]
[-- Type: text/plain, Size: 864 bytes --]
The driver includes <asm/io.h> where it should be including <linux/io.h>
and also includes <mach/hardware.h> and <asm/dma.h> without using anything
from these.
Signed-off-by; Ben Dooks <ben@simtec.co.uk>
---
drivers/spi/spi_s3c24xx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Index: b/drivers/spi/spi_s3c24xx.c
===================================================================
--- a/drivers/spi/spi_s3c24xx.c 2009-07-28 15:19:28.000000000 +0100
+++ b/drivers/spi/spi_s3c24xx.c 2009-07-28 15:20:16.000000000 +0100
@@ -20,14 +20,11 @@
#include <linux/clk.h>
#include <linux/platform_device.h>
#include <linux/gpio.h>
+#include <linux/io.h>
#include <linux/spi/spi.h>
#include <linux/spi/spi_bitbang.h>
-#include <asm/io.h>
-#include <asm/dma.h>
-#include <mach/hardware.h>
-
#include <plat/regs-spi.h>
#include <mach/spi.h>
--
next prev parent reply other threads:[~2009-08-13 10:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 10:06 [patch 0/7] SPI fixes for documentation and spi_s3c24xx driver Ben Dooks
2009-08-13 10:06 ` [patch 1/7] spi: fix spelling of automatically in documentation Ben Dooks
2009-08-13 10:06 ` [patch 2/7] spi_s3c24xx: fix clock rate calculation Ben Dooks
2009-08-13 10:06 ` [patch 3/7] spi_s3c24xx; Fix transfer setup code Ben Dooks
2009-08-13 10:06 ` Ben Dooks
2009-08-13 10:06 ` Ben Dooks [this message]
2009-08-13 10:06 ` [patch 4/7] spi_s3c24xx: fix header includes Ben Dooks
2009-08-13 10:06 ` [patch 5/7] spi_s3c24xx: use resource_size() to get resource size Ben Dooks
2009-08-13 10:06 ` Ben Dooks
2009-08-13 10:06 ` [patch 6/7] spi_s3c24xx: use dev_pm_ops Ben Dooks
2009-08-13 10:06 ` Ben Dooks
2009-08-13 10:06 ` [patch 7/7] spi_s3c24xx: cache device setup data Ben Dooks
2009-08-13 21:24 ` [patch 0/7] SPI fixes for documentation and spi_s3c24xx driver Andrew Morton
2009-08-14 14:06 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813100638.799449205@fluff.org \
--to=ben-y5a6d6n0/kfqxopxs62xeg@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uv+2+P5yyue3@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.