From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Fischer, Anna" <anna.fischer@hp.com>
Cc: "Dickson, Mike (ISS Software)" <mike.dickson@hp.com>,
Arnd Bergmann <arnd@arndb.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"Paul Congdon (UC Davis)" <ptcongdon@ucdavis.edu>,
"bridge@osdl.org" <bridge@osdl.org>,
"adobriyan@gmail.com" <adobriyan@gmail.com>,
"evb@yahoogroups.com" <evb@yahoogroups.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH] net/bridge: Add 'hairpin' port forwarding mode
Date: Thu, 13 Aug 2009 11:07:44 -0700 [thread overview]
Message-ID: <20090813110744.09465f76@nehalam> (raw)
In-Reply-To: <0199E0D51A61344794750DC57738F58E6D6B0C70D9@GVW1118EXC.americas.hpqcorp.net>
> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> index eb404dc..e486f1f 100644
> --- a/net/bridge/br_if.c
> +++ b/net/bridge/br_if.c
> @@ -256,6 +256,7 @@ static struct net_bridge_port *new_nbp(struct net_bridge *br,
> p->path_cost = port_cost(dev);
> p->priority = 0x8000 >> BR_PORT_BITS;
> p->port_no = index;
> + p->flags = 0;
> br_init_port(p);
> p->state = BR_STATE_DISABLED;
> br_stp_port_timer_init(p);
Minor nit. this is unnecessary since the structure is allocated with kzalloc.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Fischer, Anna" <anna.fischer@hp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Paul Congdon (UC Davis)" <ptcongdon@ucdavis.edu>,
"evb@yahoogroups.com" <evb@yahoogroups.com>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"kaber@trash.net" <kaber@trash.net>,
Arnd Bergmann <arnd@arndb.de>,
"Dickson, Mike (ISS Software)" <mike.dickson@hp.com>,
"adobriyan@gmail.com" <adobriyan@gmail.com>,
"bridge@osdl.org" <bridge@osdl.org>
Subject: Re: [PATCH] net/bridge: Add 'hairpin' port forwarding mode
Date: Thu, 13 Aug 2009 11:07:44 -0700 [thread overview]
Message-ID: <20090813110744.09465f76@nehalam> (raw)
In-Reply-To: <0199E0D51A61344794750DC57738F58E6D6B0C70D9@GVW1118EXC.americas.hpqcorp.net>
> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> index eb404dc..e486f1f 100644
> --- a/net/bridge/br_if.c
> +++ b/net/bridge/br_if.c
> @@ -256,6 +256,7 @@ static struct net_bridge_port *new_nbp(struct net_bridge *br,
> p->path_cost = port_cost(dev);
> p->priority = 0x8000 >> BR_PORT_BITS;
> p->port_no = index;
> + p->flags = 0;
> br_init_port(p);
> p->state = BR_STATE_DISABLED;
> br_stp_port_timer_init(p);
Minor nit. this is unnecessary since the structure is allocated with kzalloc.
next prev parent reply other threads:[~2009-08-13 18:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 16:55 [Bridge] [PATCH] net/bridge: Add 'hairpin' port forwarding mode Fischer, Anna
2009-08-13 16:55 ` Fischer, Anna
2009-08-13 17:06 ` [Bridge] " Arnd Bergmann
2009-08-13 17:06 ` Arnd Bergmann
2009-08-13 17:06 ` Arnd Bergmann
2009-08-13 18:07 ` Stephen Hemminger [this message]
2009-08-13 18:07 ` Stephen Hemminger
2009-08-13 18:07 ` Stephen Hemminger
2009-08-13 23:27 ` [Bridge] " David Miller
2009-08-13 23:27 ` David Miller
2009-08-14 21:41 ` [Bridge] [RFC] bridge: prevent hairpin and STP problems? Stephen Hemminger
2009-08-14 21:41 ` Stephen Hemminger
2009-08-17 21:16 ` [Bridge] " Fischer, Anna
2009-08-17 21:16 ` Fischer, Anna
2009-08-17 22:37 ` [Bridge] " Stephen Hemminger
2009-08-17 22:37 ` Stephen Hemminger
2009-08-13 23:27 ` [PATCH] net/bridge: Add 'hairpin' port forwarding mode David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813110744.09465f76@nehalam \
--to=shemminger@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=anna.fischer@hp.com \
--cc=arnd@arndb.de \
--cc=bridge@lists.linux-foundation.org \
--cc=bridge@osdl.org \
--cc=davem@davemloft.net \
--cc=evb@yahoogroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.dickson@hp.com \
--cc=netdev@vger.kernel.org \
--cc=ptcongdon@ucdavis.edu \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.