All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krishna Kumar <krkumar2@in.ibm.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: kaber@trash.net, netdev@vger.kernel.org, davem@davemloft.net,
	Krishna Kumar <krkumar2@in.ibm.com>,
	herbert@gondor.apana.org.au
Subject: Re: [PATCH] Speed-up pfifo_fast lookup using a bitmap
Date: Fri, 14 Aug 2009 18:54:58 +0530	[thread overview]
Message-ID: <20090814132458.27518.65144.sendpatchset@localhost.localdomain> (raw)

Hi Jarek,

Jarek Poplawski <jarkao2@gmail.com> wrote on 08/14/2009 04:31:27 PM:

> Alas, private or public, these values are lower on average than
> before, so I'm not sure the complexity (especially in reading) added
> by this patch is worth it. So, I can only say it looks formally OK,
> except the changelog and maybe 2 cosmetical suggestions below.

Maybe the different test parameters result in smaller improvements.
I agree with you - the first approach is very readable and probably
preferable, while the second introduces a new structure and more
complexity.

I am sending both these versions a last time, after fixing your
comments in case someone can help decide if one or the other is
better (sorry I forgot to run checkpatch couple of times, will try
to remember next time).

Thanks,

- KK

             reply	other threads:[~2009-08-14 13:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-14 13:24 Krishna Kumar [this message]
2009-08-14 13:25 ` [PATCH v1] Speed-up pfifo_fast lookup using a public bitmap Krishna Kumar
2009-08-14 13:25 ` [PATCH v2] Speed-up pfifo_fast lookup using a private bitmap Krishna Kumar
2009-08-14 21:36 ` [PATCH] Speed-up pfifo_fast lookup using a bitmap Jarek Poplawski
2009-08-18  2:03   ` David Miller
2009-08-18 16:46     ` Krishna Kumar2
  -- strict thread matches above, loose matches on Subject: below --
2009-08-14  8:19 Krishna Kumar
2009-08-14 11:01 ` Jarek Poplawski
2009-08-13  7:28 Krishna Kumar
2009-08-13 10:08 ` Jarek Poplawski
2009-08-13 10:41   ` Krishna Kumar2
2009-08-13 11:27     ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090814132458.27518.65144.sendpatchset@localhost.localdomain \
    --to=krkumar2@in.ibm.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkao2@gmail.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.