[PATCH] Blackfin: Fix link errors with binutils 2.19 and GCC 4.3

[PATCH] Blackfin: Fix link errors with binutils 2.19 and GCC 4.3

[Ingo Molnar]

Not sure whether this has been reported/fixed before.

Today I built a Blackfin tool-chain from scratch for -tip testing, 
and it triggers:

  arch/blackfin/kernel/vmlinux.lds:1238: undefined section `.data_a_l1' referenced in expression

and:

  arch/blackfin/kernel/vmlinux.lds:1238: undefined section `.text_data_l1'
referenced in expression

Now i dont have any way to test this linker script, but it now at 
least builds fine after fixing what appears to be typos in those 
assert statements.

Cc: Mike Frysinger <vapier@gentoo.org>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/blackfin/kernel/vmlinux.lds.S |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/blackfin/kernel/vmlinux.lds.S b/arch/blackfin/kernel/vmlinux.lds.S
index 6ac307c..77f8659 100644
--- a/arch/blackfin/kernel/vmlinux.lds.S
+++ b/arch/blackfin/kernel/vmlinux.lds.S
@@ -221,7 +221,7 @@ SECTIONS
 		. = ALIGN(4);
 		__ebss_l1 = .;
 	}
-	ASSERT (SIZEOF(.data_a_l1) <= L1_DATA_A_LENGTH, "L1 data A overflow!")
+	ASSERT (SIZEOF(.data_l1) <= L1_DATA_A_LENGTH, "L1 data A overflow!")
 
 	.data_b_l1 L1_DATA_B_START : AT(LOADADDR(.data_l1) + SIZEOF(.data_l1))
 	{
@@ -262,7 +262,7 @@ SECTIONS
 		. = ALIGN(4);
 		__ebss_l2 = .;
 	}
-	ASSERT (SIZEOF(.text_data_l1) <= L2_LENGTH, "L2 overflow!")
+	ASSERT (SIZEOF(.text_data_l2) <= L2_LENGTH, "L2 overflow!")
 
 	/* Force trailing alignment of our init section so that when we
 	 * free our init memory, we don't leave behind a partial page.

Re: [PATCH] Blackfin: Fix link errors with binutils 2.19 and GCC 4.3

[Mike Frysinger]

On Tue, Aug 18, 2009 at 10:58, Ingo Molnar wrote:
> Not sure whether this has been reported/fixed before.
>
> Today I built a Blackfin tool-chain from scratch for -tip testing,
> and it triggers:
>
>  arch/blackfin/kernel/vmlinux.lds:1238: undefined section `.data_a_l1' referenced in expression
>
> and:
>
>  arch/blackfin/kernel/vmlinux.lds:1238: undefined section `.text_data_l1'
> referenced in expression
>
> Now i dont have any way to test this linker script, but it now at
> least builds fine after fixing what appears to be typos in those
> assert statements.

they're def typos made when i copy & pasted earlier lines.  but
binutils-2.17 apparently doesnt mind which is why i didnt notice.  ive
merged this into the Blackfin tree, thanks
-mike

Re: [PATCH] Blackfin: Fix link errors with binutils 2.19 and GCC 4.3

[Ingo Molnar]

* Mike Frysinger <vapier.adi@gmail.com> wrote:

> On Tue, Aug 18, 2009 at 10:58, Ingo Molnar wrote:
> > Not sure whether this has been reported/fixed before.
> >
> > Today I built a Blackfin tool-chain from scratch for -tip testing,
> > and it triggers:
> >
> >  arch/blackfin/kernel/vmlinux.lds:1238: undefined section `.data_a_l1' referenced in expression
> >
> > and:
> >
> >  arch/blackfin/kernel/vmlinux.lds:1238: undefined section `.text_data_l1'
> > referenced in expression
> >
> > Now i dont have any way to test this linker script, but it now at
> > least builds fine after fixing what appears to be typos in those
> > assert statements.
> 
> they're def typos made when i copy & pasted earlier lines.  but 
> binutils-2.17 apparently doesnt mind which is why i didnt notice.  
> ive merged this into the Blackfin tree, thanks

yeah, i used binutils-2.19.1.

	Ingo