From: Greg KH <gregkh@suse.de>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
Kumar Gala <galak@kernel.crashing.org>,
spi-devel-general@lists.sourceforge.net, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] powerpc/qe&cpm: Implement static inline stubs for non-QE/CPM builds
Date: Tue, 18 Aug 2009 15:27:47 -0700 [thread overview]
Message-ID: <20090818222747.GB4354@suse.de> (raw)
In-Reply-To: <20090818220418.GD25090@oksana.dev.rtsoft.ru>
On Wed, Aug 19, 2009 at 02:04:18AM +0400, Anton Vorontsov wrote:
> This is needed to avoid ugly #ifdefs in drivers. Also update fsl_qe_udc
> driver so that now it doesn't define its own versions that cause build
> breakage when the generic stubs are used.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
As you're just deleting code, I'll ack that :)
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Hopefully you have tested building this thing...
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
spi-devel-general@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 4/8] powerpc/qe&cpm: Implement static inline stubs for non-QE/CPM builds
Date: Tue, 18 Aug 2009 15:27:47 -0700 [thread overview]
Message-ID: <20090818222747.GB4354@suse.de> (raw)
In-Reply-To: <20090818220418.GD25090@oksana.dev.rtsoft.ru>
On Wed, Aug 19, 2009 at 02:04:18AM +0400, Anton Vorontsov wrote:
> This is needed to avoid ugly #ifdefs in drivers. Also update fsl_qe_udc
> driver so that now it doesn't define its own versions that cause build
> breakage when the generic stubs are used.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
As you're just deleting code, I'll ack that :)
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Hopefully you have tested building this thing...
thanks,
greg k-h
next prev parent reply other threads:[~2009-08-18 22:27 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 22:03 [PATCH v2 0/8] spi_mpc8xxx: Add support for DMA transfers Anton Vorontsov
2009-08-18 22:03 ` Anton Vorontsov
2009-08-18 22:04 ` [PATCH 1/8] powerpc/cpm: Remove SPI defines and spi structs Anton Vorontsov
2009-08-18 22:04 ` Anton Vorontsov
2009-08-28 5:45 ` Kumar Gala
2009-08-28 5:45 ` Kumar Gala
2009-09-28 17:34 ` Anton Vorontsov
2009-09-28 17:34 ` Anton Vorontsov
2009-08-18 22:04 ` [PATCH 3/8] powerpc/cpm: Move CPMFCR_* defines into cpm.h Anton Vorontsov
2009-08-18 22:04 ` Anton Vorontsov
[not found] ` <20090818220416.GC25090-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-08-28 5:45 ` Kumar Gala
2009-08-28 5:45 ` Kumar Gala
2009-08-28 5:45 ` Kumar Gala
2009-08-18 22:04 ` [PATCH 4/8] powerpc/qe&cpm: Implement static inline stubs for non-QE/CPM builds Anton Vorontsov
2009-08-18 22:04 ` Anton Vorontsov
2009-08-18 22:27 ` Greg KH [this message]
2009-08-18 22:27 ` Greg KH
2009-08-18 23:47 ` Anton Vorontsov
2009-08-18 23:47 ` Anton Vorontsov
2009-08-28 5:45 ` Kumar Gala
2009-08-28 5:45 ` Kumar Gala
[not found] ` <20090818220304.GA23640-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-08-18 22:04 ` [PATCH 2/8] powerpc/qe&cpm2: Avoid redefinitions in CPM2 and QE headers Anton Vorontsov
2009-08-18 22:04 ` Anton Vorontsov
2009-08-18 22:04 ` Anton Vorontsov
[not found] ` <20090818220415.GB25090-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-08-28 5:45 ` Kumar Gala
2009-08-28 5:45 ` Kumar Gala
2009-08-28 5:45 ` Kumar Gala
2009-08-18 22:04 ` [PATCH 5/8] spi_mpc8xxx: Fix uninitialized variable Anton Vorontsov
2009-08-18 22:04 ` Anton Vorontsov
2009-08-18 22:04 ` Anton Vorontsov
2009-08-28 5:48 ` Kumar Gala
2009-08-28 5:48 ` Kumar Gala
2009-08-18 22:04 ` [PATCH 6/8] spi_mpc8xxx: Factor out SPI mode change steps into a call Anton Vorontsov
2009-08-18 22:04 ` Anton Vorontsov
2009-08-18 22:04 ` [PATCH 7/8] spi_mpc8xxx: Turn qe_mode into flags Anton Vorontsov
2009-08-18 22:04 ` Anton Vorontsov
2009-08-18 22:04 ` [PATCH 8/8] spi_mpc8xxx: Add support for QE DMA mode and CPM1/CPM2 chips Anton Vorontsov
2009-08-18 22:04 ` Anton Vorontsov
2009-08-28 4:41 ` [PATCH v2 0/8] spi_mpc8xxx: Add support for DMA transfers David Brownell
2009-08-28 4:41 ` David Brownell
2009-09-04 16:37 ` Anton Vorontsov
2009-09-04 16:37 ` Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2009-10-12 16:48 [RESEND][PATCH " Anton Vorontsov
[not found] ` <20091012164841.GA32214-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-10-12 16:49 ` [PATCH 4/8] powerpc/qe&cpm: Implement static inline stubs for non-QE/CPM builds Anton Vorontsov
2009-10-12 16:49 ` Anton Vorontsov
2009-10-12 16:49 ` Anton Vorontsov
2009-11-05 13:46 ` Kumar Gala
2009-11-05 13:46 ` Kumar Gala
2009-08-14 22:24 [PATCH 0/8] spi_mpc8xxx: Add support for DMA transfers Anton Vorontsov
2009-08-14 22:25 ` [PATCH 4/8] powerpc/qe&cpm: Implement static inline stubs for non-QE/CPM builds Anton Vorontsov
2009-08-14 22:25 ` Anton Vorontsov
2009-08-17 13:53 ` Anton Vorontsov
2009-08-17 13:53 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090818222747.GB4354@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=dbrownell@users.sourceforge.net \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.