From: Stephen Hemminger <shemminger@vyatta.com>
To: Petri Gynther <pgynther@google.com>
Cc: David Miller <davem@davemloft.net>,
benh@kernel.crashing.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ibm_newemac: emac_close() needs to call netif_carrier_off()
Date: Wed, 19 Aug 2009 16:48:56 -0700 [thread overview]
Message-ID: <20090819164856.2ed8b666@s6510> (raw)
In-Reply-To: <fc21faff0908191532i2de570a1g1a6674bf5fe64a05@mail.gmail.com>
On Wed, 19 Aug 2009 15:32:41 -0700
Petri Gynther <pgynther@google.com> wrote:
> Stephen,
>
> I think your suggestion of adding netif_running() check to
> bond_check_dev_link() is valid and a good fix to the bonding driver.
> We can do this in a separate patch.
>
> However, I think that the change to ibm_newemac: emac_close() is
> needed as well. ibm_newemac netdevs should not return
> netif_carrier_ok() == TRUE when they have been shut down.
I concur. Fixing the possible problems in both places is best.
next prev parent reply other threads:[~2009-08-19 23:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 21:00 [PATCH] ibm_newemac: emac_close() needs to call netif_carrier_off() Petri Gynther
2009-08-19 21:11 ` Stephen Hemminger
2009-08-19 21:34 ` David Miller
2009-08-19 21:40 ` Petri Gynther
2009-08-19 22:32 ` Petri Gynther
2009-08-19 23:48 ` Stephen Hemminger [this message]
2009-08-20 6:02 ` Benjamin Herrenschmidt
2009-08-20 9:20 ` David Miller
2009-08-20 9:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819164856.2ed8b666@s6510 \
--to=shemminger@vyatta.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.