From: Jarkko Nikula <jhnikula@gmail.com>
To: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Cc: alsa-devel@alsa-project.org, linux-sh@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>,
broonie@opensource.wolfsonmicro.com,
Magnus Damm <magnus.damm@gmail.com>,
lethal@linux-sh.org
Subject: Re: [PATCH v2 1/4] Add SuperH FSI driver support for ALSA
Date: Thu, 20 Aug 2009 15:22:12 +0300 [thread overview]
Message-ID: <20090820152212.b8be38b9.jhnikula@gmail.com> (raw)
In-Reply-To: <uy6ped79a.wl%morimoto.kuninori@renesas.com>
Hi
On Thu, 20 Aug 2009 21:01:05 +0900
Kuninori Morimoto <morimoto.kuninori@renesas.com> wrote:
> This driver is very simple.
> It support playback only now.
> This patch is tested by ms7724se board.
>
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> v1 -> v2
>
> o it direct use clk_enable/disable
> o rename fsi.h -> sh_fsi.h
>
> include/sound/sh_fsi.h | 83 ++++
> sound/soc/sh/Kconfig | 7 +-
> sound/soc/sh/Makefile | 2 +
> sound/soc/sh/fsi.c | 1004 ++++++++++++++++++++++++++++++++++++++++++++++++
I'm not familiar with the SH but this arch specific header file
sh_fsi.h should go either into sound/soc/sh or if generic enough, then
somewhere under arch/sh/include/.
--
Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Nikula <jhnikula@gmail.com>
To: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Cc: alsa-devel@alsa-project.org, linux-sh@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>,
broonie@opensource.wolfsonmicro.com,
Magnus Damm <magnus.damm@gmail.com>,
lethal@linux-sh.org
Subject: Re: [alsa-devel] [PATCH v2 1/4] Add SuperH FSI driver support for
Date: Thu, 20 Aug 2009 12:22:12 +0000 [thread overview]
Message-ID: <20090820152212.b8be38b9.jhnikula@gmail.com> (raw)
In-Reply-To: <uy6ped79a.wl%morimoto.kuninori@renesas.com>
Hi
On Thu, 20 Aug 2009 21:01:05 +0900
Kuninori Morimoto <morimoto.kuninori@renesas.com> wrote:
> This driver is very simple.
> It support playback only now.
> This patch is tested by ms7724se board.
>
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> v1 -> v2
>
> o it direct use clk_enable/disable
> o rename fsi.h -> sh_fsi.h
>
> include/sound/sh_fsi.h | 83 ++++
> sound/soc/sh/Kconfig | 7 +-
> sound/soc/sh/Makefile | 2 +
> sound/soc/sh/fsi.c | 1004 ++++++++++++++++++++++++++++++++++++++++++++++++
I'm not familiar with the SH but this arch specific header file
sh_fsi.h should go either into sound/soc/sh or if generic enough, then
somewhere under arch/sh/include/.
--
Jarkko
next prev parent reply other threads:[~2009-08-20 12:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 12:01 [PATCH v2 1/4] Add SuperH FSI driver support for ALSA Kuninori Morimoto
2009-08-20 12:01 ` Kuninori Morimoto
2009-08-20 12:22 ` Jarkko Nikula [this message]
2009-08-20 12:22 ` [alsa-devel] [PATCH v2 1/4] Add SuperH FSI driver support for Jarkko Nikula
2009-08-20 12:39 ` [alsa-devel] [PATCH v2 1/4] Add SuperH FSI driver support for ALSA Mark Brown
2009-08-20 12:39 ` [alsa-devel] [PATCH v2 1/4] Add SuperH FSI driver support for Mark Brown
2009-08-20 12:44 ` [alsa-devel] [PATCH v2 1/4] Add SuperH FSI driver support for ALSA Magnus Damm
2009-08-20 12:44 ` [alsa-devel] [PATCH v2 1/4] Add SuperH FSI driver support for Magnus Damm
2009-08-20 12:59 ` Jarkko Nikula
2009-08-20 13:00 ` [alsa-devel] [PATCH v2 1/4] Add SuperH FSI driver support for ALSA Jarkko Nikula
2009-08-20 19:02 ` Mark Brown
2009-08-20 19:02 ` [alsa-devel] [PATCH v2 1/4] Add SuperH FSI driver support for Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820152212.b8be38b9.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=morimoto.kuninori@renesas.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.