All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Gianluca Guida <gianluca.guida@citrix.com>
Cc: Gianluca Guida <Gianluca.Guida@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Konrad Rzeszutek Wilk <kliw@darnok.org>
Subject: Re: [PATCH] Include in balloon page tracking only PFNs which are marked as RAM in E820.
Date: Thu, 20 Aug 2009 12:43:08 -0400	[thread overview]
Message-ID: <20090820164308.GB28012@phenom.dumpdata.com> (raw)
In-Reply-To: <19085.29617.299035.903514@gianluca.uk.xensource.com>

On Thu, Aug 20, 2009 at 05:02:57PM +0100, Gianluca Guida wrote:
> Hi,
> 
> Ok, by looking at this patch it's clear that you are testing with a
> kernel that tries to allow kernels to boot ballooned.
> 
> In this case the patch is correct. Since the patch is actually
> reverted, I think we should wait to apply it until I succeed to
> reproduce the bug that caused Jeremy to revert it.

You are talking about the 7394b25905929a92e51771b832ee67b70ccebcf0 patch?
I will wait and if this patch is still needed I will send it out to LKML/xen-devel
with your style comment.


>  > > +   		int is_ram = page_is_ram(pfn);
> 
> Do you really need to declare this as a variable? couldn't you put the

Not at all. Right after I sent it out I realized it would have been looking
better without.

> expression in the if statement?

      reply	other threads:[~2009-08-20 16:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-19 19:12 [PATCH XEN-UNSTABLE PV_OPS] Balloon fix Konrad Rzeszutek Wilk
2009-08-19 19:12 ` [PATCH] Include in balloon page tracking only PFNs which are marked as RAM in E820 Konrad Rzeszutek Wilk
2009-08-19 19:16   ` Konrad Rzeszutek Wilk
2009-08-20 16:02     ` Gianluca Guida
2009-08-20 16:43       ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090820164308.GB28012@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=Gianluca.Guida@eu.citrix.com \
    --cc=gianluca.guida@citrix.com \
    --cc=kliw@darnok.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.