From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shine Liu <shinel@foxmail.com>
Cc: ben@simtec.co.uk, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: s3c24xx platform: Fix s3c2410_dma_started called at wrong time
Date: Thu, 20 Aug 2009 19:47:14 +0100 [thread overview]
Message-ID: <20090820184714.GD5032@sirena.org.uk> (raw)
In-Reply-To: <1250783107.1404.70.camel@sl>
On Thu, Aug 20, 2009 at 11:45:07PM +0800, Shine Liu wrote:
> > The callback doesn't need to be set up within the trigger function - if
> > it's done before the trigger functions are called then the DMA trigger
> > can call it. Off the top of my head I'd expect it's possible to set it
> > up when the device is opened.
> Who call the DMA trigger? When? In any of the platform/cpu_dai trigger
> functions?
It's called ultimately by user space; within ASoC it's always called by
the core trigger function in the fixed order that it has. The open()
callback would be a safe place to do the setup - that's called before
anything else.
next prev parent reply other threads:[~2009-08-20 19:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 9:42 [PATCH] ASoC: s3c24xx platform: Fix s3c2410_dma_started called at wrong time Shine Liu
2009-08-20 10:15 ` Mark Brown
2009-08-20 11:59 ` Shine Liu
2009-08-20 12:18 ` Mark Brown
2009-08-20 13:38 ` Shine Liu
2009-08-20 14:52 ` Mark Brown
2009-08-20 15:45 ` Shine Liu
2009-08-20 18:47 ` Mark Brown [this message]
2009-08-21 10:00 ` Shine Liu
2009-08-23 10:28 ` Mark Brown
2009-08-23 11:37 ` Shine Liu
[not found] ` <20090824101733.GA3591@rakim.wolfsonmicro.main>
2009-08-24 11:54 ` Shine Liu
2009-08-24 12:05 ` Mark Brown
2009-08-24 13:31 ` Shine Liu
2009-08-25 3:04 ` [PATCH] ASoC: S3C platform: Fix s3c2410_dma_started() called at improper time Shine Liu
2009-08-25 10:33 ` Mark Brown
2009-08-25 12:05 ` Shine Liu
2009-08-25 12:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820184714.GD5032@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben@simtec.co.uk \
--cc=shinel@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.