From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shine Liu <shinel@foxmail.com>
Cc: alsa-devel@alsa-project.org, ben-linux@fluff.org
Subject: Re: [PATCH] ASoC: S3C platform: Fix s3c2410_dma_started() called at improper time
Date: Tue, 25 Aug 2009 11:33:29 +0100 [thread overview]
Message-ID: <20090825103328.GA31012@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1251169466.4272.22.camel@shinel>
On Tue, Aug 25, 2009 at 11:04:26AM +0800, Shine Liu wrote:
> I think before we fix the bug in the callback way, we can use this
> patch provisionally for a while though it seems a little ugly.
I can't prevail on you to do this with a callback within the ASoC code
only? This really does seem like something that's created by the way
ASoC is structured rather than a general S3C DMA issue so I'm not sure
that the arch/arm code needs to be changed at all.
Otherwise the patch looks OK, in fact I'd tone down the comments about
it being a hack to do this - ASoC DAI and PCM drivers are supposed to be
fairly closely tied to each other.
next prev parent reply other threads:[~2009-08-25 10:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 9:42 [PATCH] ASoC: s3c24xx platform: Fix s3c2410_dma_started called at wrong time Shine Liu
2009-08-20 10:15 ` Mark Brown
2009-08-20 11:59 ` Shine Liu
2009-08-20 12:18 ` Mark Brown
2009-08-20 13:38 ` Shine Liu
2009-08-20 14:52 ` Mark Brown
2009-08-20 15:45 ` Shine Liu
2009-08-20 18:47 ` Mark Brown
2009-08-21 10:00 ` Shine Liu
2009-08-23 10:28 ` Mark Brown
2009-08-23 11:37 ` Shine Liu
[not found] ` <20090824101733.GA3591@rakim.wolfsonmicro.main>
2009-08-24 11:54 ` Shine Liu
2009-08-24 12:05 ` Mark Brown
2009-08-24 13:31 ` Shine Liu
2009-08-25 3:04 ` [PATCH] ASoC: S3C platform: Fix s3c2410_dma_started() called at improper time Shine Liu
2009-08-25 10:33 ` Mark Brown [this message]
2009-08-25 12:05 ` Shine Liu
2009-08-25 12:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090825103328.GA31012@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=shinel@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.