* [Ocfs2-devel] [PATCH] ocfs2: Add missing lock name
@ 2009-08-20 16:26 Jan Kara
2009-08-20 16:36 ` Sunil Mushran
2009-08-20 23:59 ` Joel Becker
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kara @ 2009-08-20 16:26 UTC (permalink / raw)
To: ocfs2-devel
There is missing name for NFSSync cluster lock. This makes lockdep unhappy
because we end up passing NULL to lockdep when initializing lock key. Fix it.
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ocfs2/ocfs2_lockid.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/ocfs2/ocfs2_lockid.h b/fs/ocfs2/ocfs2_lockid.h
index fcdba09..c212cf5 100644
--- a/fs/ocfs2/ocfs2_lockid.h
+++ b/fs/ocfs2/ocfs2_lockid.h
@@ -108,6 +108,7 @@ static char *ocfs2_lock_type_strings[] = {
[OCFS2_LOCK_TYPE_OPEN] = "Open",
[OCFS2_LOCK_TYPE_FLOCK] = "Flock",
[OCFS2_LOCK_TYPE_QINFO] = "Quota",
+ [OCFS2_LOCK_TYPE_NFS_SYNC] = "NFSSync",
[OCFS2_LOCK_TYPE_ORPHAN_SCAN] = "OrphanScan",
};
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: Add missing lock name
2009-08-20 16:26 [Ocfs2-devel] [PATCH] ocfs2: Add missing lock name Jan Kara
@ 2009-08-20 16:36 ` Sunil Mushran
2009-08-20 23:59 ` Joel Becker
1 sibling, 0 replies; 3+ messages in thread
From: Sunil Mushran @ 2009-08-20 16:36 UTC (permalink / raw)
To: ocfs2-devel
Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
Jan Kara wrote:
> There is missing name for NFSSync cluster lock. This makes lockdep unhappy
> because we end up passing NULL to lockdep when initializing lock key. Fix it.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ocfs2/ocfs2_lockid.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ocfs2/ocfs2_lockid.h b/fs/ocfs2/ocfs2_lockid.h
> index fcdba09..c212cf5 100644
> --- a/fs/ocfs2/ocfs2_lockid.h
> +++ b/fs/ocfs2/ocfs2_lockid.h
> @@ -108,6 +108,7 @@ static char *ocfs2_lock_type_strings[] = {
> [OCFS2_LOCK_TYPE_OPEN] = "Open",
> [OCFS2_LOCK_TYPE_FLOCK] = "Flock",
> [OCFS2_LOCK_TYPE_QINFO] = "Quota",
> + [OCFS2_LOCK_TYPE_NFS_SYNC] = "NFSSync",
> [OCFS2_LOCK_TYPE_ORPHAN_SCAN] = "OrphanScan",
> };
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: Add missing lock name
2009-08-20 16:26 [Ocfs2-devel] [PATCH] ocfs2: Add missing lock name Jan Kara
2009-08-20 16:36 ` Sunil Mushran
@ 2009-08-20 23:59 ` Joel Becker
1 sibling, 0 replies; 3+ messages in thread
From: Joel Becker @ 2009-08-20 23:59 UTC (permalink / raw)
To: ocfs2-devel
On Thu, Aug 20, 2009 at 06:26:52PM +0200, Jan Kara wrote:
> There is missing name for NFSSync cluster lock. This makes lockdep unhappy
> because we end up passing NULL to lockdep when initializing lock key. Fix it.
This is now part of the fixes branch of ocfs2.git.
Joel
--
"Not everything that can be counted counts, and not everything
that counts can be counted."
- Albert Einstein
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-20 23:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-20 16:26 [Ocfs2-devel] [PATCH] ocfs2: Add missing lock name Jan Kara
2009-08-20 16:36 ` Sunil Mushran
2009-08-20 23:59 ` Joel Becker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.