From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: Jiri Kosina <trivial@kernel.org>
Cc: Corey Minyard <minyard@acm.org>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] char/impi: adding __init macro/ fix of __exit macro location in ipmi_poweroff.c
Date: Sat, 22 Aug 2009 23:46:55 +0000 [thread overview]
Message-ID: <200908230146.56283.PeterHuewe@gmx.de> (raw)
From: Peter Huewe <peterhuewe@gmx.de>
Trivial patch which adds the __init to the module_init function of
drivers/char/ipmi/ipmy_poweroff.c and corrects the location of __exit for the
cleanup function.
According to ldd3, page 31 the __exit token hast to be after the return type.
Or am I getting something wrong here?
Corey, please have a look at the small patch and either pull it through
your tree, or please ack' it so Jiri can pull it through the trivial tree.
linux version 2.6.31-rc6 - linus git tree, So 23. Aug 01:38:43 CEST 2009
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
index a261bd7..2e66b5f 100644
--- a/drivers/char/ipmi/ipmi_poweroff.c
+++ b/drivers/char/ipmi/ipmi_poweroff.c
@@ -691,7 +691,7 @@ static struct ctl_table_header *ipmi_table_header;
/*
* Startup and shutdown functions.
*/
-static int ipmi_poweroff_init(void)
+static int __init ipmi_poweroff_init(void)
{
int rv;
@@ -725,7 +725,7 @@ static int ipmi_poweroff_init(void)
}
#ifdef MODULE
-static __exit void ipmi_poweroff_cleanup(void)
+static void __exit ipmi_poweroff_cleanup(void)
{
int rv;
WARNING: multiple messages have this Message-ID (diff)
From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: Jiri Kosina <trivial@kernel.org>
Cc: Corey Minyard <minyard@acm.org>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] char/impi: adding __init macro/ fix of __exit macro location in ipmi_poweroff.c
Date: Sun, 23 Aug 2009 01:46:55 +0200 [thread overview]
Message-ID: <200908230146.56283.PeterHuewe@gmx.de> (raw)
From: Peter Huewe <peterhuewe@gmx.de>
Trivial patch which adds the __init to the module_init function of
drivers/char/ipmi/ipmy_poweroff.c and corrects the location of __exit for the
cleanup function.
According to ldd3, page 31 the __exit token hast to be after the return type.
Or am I getting something wrong here?
Corey, please have a look at the small patch and either pull it through
your tree, or please ack' it so Jiri can pull it through the trivial tree.
linux version 2.6.31-rc6 - linus git tree, So 23. Aug 01:38:43 CEST 2009
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
index a261bd7..2e66b5f 100644
--- a/drivers/char/ipmi/ipmi_poweroff.c
+++ b/drivers/char/ipmi/ipmi_poweroff.c
@@ -691,7 +691,7 @@ static struct ctl_table_header *ipmi_table_header;
/*
* Startup and shutdown functions.
*/
-static int ipmi_poweroff_init(void)
+static int __init ipmi_poweroff_init(void)
{
int rv;
@@ -725,7 +725,7 @@ static int ipmi_poweroff_init(void)
}
#ifdef MODULE
-static __exit void ipmi_poweroff_cleanup(void)
+static void __exit ipmi_poweroff_cleanup(void)
{
int rv;
next reply other threads:[~2009-08-22 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-22 23:46 Peter Hüwe [this message]
2009-08-22 23:46 ` [PATCH] char/impi: adding __init macro/ fix of __exit macro location in ipmi_poweroff.c Peter Hüwe
2009-08-24 3:10 ` [Openipmi-developer] [PATCH] char/impi: adding __init macro/ fix Corey Minyard
2009-08-24 3:10 ` [Openipmi-developer] [PATCH] char/impi: adding __init macro/ fix of __exit macro location in ipmi_poweroff.c Corey Minyard
2009-08-24 8:17 ` [Openipmi-developer] [PATCH] char/impi: adding __init macro/ Jiri Kosina
2009-08-24 8:17 ` [Openipmi-developer] [PATCH] char/impi: adding __init macro/ fix of __exit macro location in ipmi_poweroff.c Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908230146.56283.PeterHuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.