diff for duplicates of <20090824043831.GA2473@orion> diff --git a/a/1.txt b/N1/1.txt index 212a740..e9f926d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,3 +7,47 @@ On Sun, Aug 23, 2009 at 06:49:24PM -0700, David Miller wrote: > Can someone please repost the patch to netdev? I don't have a copy > handy and I'd like to see it tracked properly patchwork too. If it's > in patchwork, it won't get lost. + +>From 28b229f0f3f807d775a7e70b96c018eef935a24a Mon Sep 17 00:00:00 2001 +From: Marek Vasut <marek.vasut@gmail.com> +Date: Fri, 24 Jul 2009 02:44:02 +0200 +Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops + +This patch fixes broken pxaficp-ir. The problem was in incorrect +net_device_ops being specified which prevented the driver from +operating. The symptoms were: + - failing ifconfig for IrLAN, resulting in + SIOCSIFFLAGS: Cannot assign requested address + - irattach working for IrCOMM, but the port stayed disabled + +Moreover this patch corrects missing sysfs device link. + +Signed-off-by: Marek Vasut <marek.vasut@gmail.com> +--- + drivers/net/irda/pxaficp_ir.c | 4 +--- + 1 files changed, 1 insertions(+), 3 deletions(-) + +diff --git a/drivers/net/irda/pxaficp_ir.c b/drivers/net/irda/pxaficp_ir.c +index 4edbdbe..f5b7d83 100644 +--- a/drivers/net/irda/pxaficp_ir.c ++++ b/drivers/net/irda/pxaficp_ir.c +@@ -820,9 +820,6 @@ static const struct net_device_ops pxa_irda_netdev_ops = { + .ndo_stop = pxa_irda_stop, + .ndo_start_xmit = pxa_irda_hard_xmit, + .ndo_do_ioctl = pxa_irda_ioctl, +- .ndo_change_mtu = eth_change_mtu, +- .ndo_validate_addr = eth_validate_addr, +- .ndo_set_mac_address = eth_mac_addr, + }; + + static int pxa_irda_probe(struct platform_device *pdev) +@@ -847,6 +844,7 @@ static int pxa_irda_probe(struct platform_device *pdev) + if (!dev) + goto err_mem_3; + ++ SET_NETDEV_DEV(dev, &pdev->dev); + si = netdev_priv(dev); + si->dev = &pdev->dev; + si->pdata = pdev->dev.platform_data; +-- +1.6.3.3 diff --git a/a/content_digest b/N1/content_digest index cd46b21..3026ae9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,10 +2,17 @@ "ref\0200908220054.31438.marek.vasut@gmail.com\0" "ref\0a4423d670908231055o2bb65fe0le2c33fe94b660b38@mail.gmail.com\0" "ref\020090823.184924.26788268.davem@davemloft.net\0" - "From\0a.beregalov@gmail.com (Alexander Beregalov)\0" - "Subject\0[PATCH] pxaficp-ir - remove incorrect net_device_ops\0" + "From\0Alexander Beregalov <a.beregalov@gmail.com>\0" + "Subject\0Re: [PATCH] pxaficp-ir - remove incorrect net_device_ops\0" "Date\0Mon, 24 Aug 2009 08:38:31 +0400\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0David Miller <davem@davemloft.net>\0" + "Cc\0eric.y.miao@gmail.com" + linux-arm-kernel@lists.arm.linux.org.uk + linux@arm.linux.org.uk + samuel@sortiz.org + netdev@vger.kernel.org + linux-arm-kernel@lists.infradead.org + " marek.vasut@gmail.com\0" "\00:1\0" "b\0" "On Sun, Aug 23, 2009 at 06:49:24PM -0700, David Miller wrote:\n" @@ -16,6 +23,50 @@ "> \n" "> Can someone please repost the patch to netdev? I don't have a copy\n" "> handy and I'd like to see it tracked properly patchwork too. If it's\n" - > in patchwork, it won't get lost. + "> in patchwork, it won't get lost.\n" + "\n" + ">From 28b229f0f3f807d775a7e70b96c018eef935a24a Mon Sep 17 00:00:00 2001\n" + "From: Marek Vasut <marek.vasut@gmail.com>\n" + "Date: Fri, 24 Jul 2009 02:44:02 +0200\n" + "Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops\n" + "\n" + "This patch fixes broken pxaficp-ir. The problem was in incorrect\n" + "net_device_ops being specified which prevented the driver from\n" + "operating. The symptoms were:\n" + " - failing ifconfig for IrLAN, resulting in\n" + "\tSIOCSIFFLAGS: Cannot assign requested address\n" + " - irattach working for IrCOMM, but the port stayed disabled\n" + "\n" + "Moreover this patch corrects missing sysfs device link.\n" + "\n" + "Signed-off-by: Marek Vasut <marek.vasut@gmail.com>\n" + "---\n" + " drivers/net/irda/pxaficp_ir.c | 4 +---\n" + " 1 files changed, 1 insertions(+), 3 deletions(-)\n" + "\n" + "diff --git a/drivers/net/irda/pxaficp_ir.c b/drivers/net/irda/pxaficp_ir.c\n" + "index 4edbdbe..f5b7d83 100644\n" + "--- a/drivers/net/irda/pxaficp_ir.c\n" + "+++ b/drivers/net/irda/pxaficp_ir.c\n" + "@@ -820,9 +820,6 @@ static const struct net_device_ops pxa_irda_netdev_ops = {\n" + " \t.ndo_stop\t\t= pxa_irda_stop,\n" + " \t.ndo_start_xmit\t\t= pxa_irda_hard_xmit,\n" + " \t.ndo_do_ioctl\t\t= pxa_irda_ioctl,\n" + "-\t.ndo_change_mtu\t\t= eth_change_mtu,\n" + "-\t.ndo_validate_addr\t= eth_validate_addr,\n" + "-\t.ndo_set_mac_address\t= eth_mac_addr,\n" + " };\n" + " \n" + " static int pxa_irda_probe(struct platform_device *pdev)\n" + "@@ -847,6 +844,7 @@ static int pxa_irda_probe(struct platform_device *pdev)\n" + " \tif (!dev)\n" + " \t\tgoto err_mem_3;\n" + " \n" + "+\tSET_NETDEV_DEV(dev, &pdev->dev);\n" + " \tsi = netdev_priv(dev);\n" + " \tsi->dev = &pdev->dev;\n" + " \tsi->pdata = pdev->dev.platform_data;\n" + "-- \n" + 1.6.3.3 -f52a8ef550bfcde4eeb32c8623d2fb3afed3accd4bf24943d9f49d297e370520 +fd8480989040763ea68854a750a98a09f5ac5aaeeed5afe9d8254feb56231960
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.