From: a.beregalov@gmail.com (Alexander Beregalov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops
Date: Mon, 24 Aug 2009 08:38:31 +0400 [thread overview]
Message-ID: <20090824043831.GA2473@orion> (raw)
In-Reply-To: <20090823.184924.26788268.davem@davemloft.net>
On Sun, Aug 23, 2009 at 06:49:24PM -0700, David Miller wrote:
> From: Alexander Beregalov <a.beregalov@gmail.com>
> Date: Sun, 23 Aug 2009 21:55:45 +0400
>
> > David, please have a look. Will you apply it?
>
> Can someone please repost the patch to netdev? I don't have a copy
> handy and I'd like to see it tracked properly patchwork too. If it's
> in patchwork, it won't get lost.
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Beregalov <a.beregalov@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: eric.y.miao@gmail.com, linux-arm-kernel@lists.arm.linux.org.uk,
linux@arm.linux.org.uk, samuel@sortiz.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
marek.vasut@gmail.com
Subject: Re: [PATCH] pxaficp-ir - remove incorrect net_device_ops
Date: Mon, 24 Aug 2009 08:38:31 +0400 [thread overview]
Message-ID: <20090824043831.GA2473@orion> (raw)
In-Reply-To: <20090823.184924.26788268.davem@davemloft.net>
On Sun, Aug 23, 2009 at 06:49:24PM -0700, David Miller wrote:
> From: Alexander Beregalov <a.beregalov@gmail.com>
> Date: Sun, 23 Aug 2009 21:55:45 +0400
>
> > David, please have a look. Will you apply it?
>
> Can someone please repost the patch to netdev? I don't have a copy
> handy and I'd like to see it tracked properly patchwork too. If it's
> in patchwork, it won't get lost.
>From 28b229f0f3f807d775a7e70b96c018eef935a24a Mon Sep 17 00:00:00 2001
From: Marek Vasut <marek.vasut@gmail.com>
Date: Fri, 24 Jul 2009 02:44:02 +0200
Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops
This patch fixes broken pxaficp-ir. The problem was in incorrect
net_device_ops being specified which prevented the driver from
operating. The symptoms were:
- failing ifconfig for IrLAN, resulting in
SIOCSIFFLAGS: Cannot assign requested address
- irattach working for IrCOMM, but the port stayed disabled
Moreover this patch corrects missing sysfs device link.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
drivers/net/irda/pxaficp_ir.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/irda/pxaficp_ir.c b/drivers/net/irda/pxaficp_ir.c
index 4edbdbe..f5b7d83 100644
--- a/drivers/net/irda/pxaficp_ir.c
+++ b/drivers/net/irda/pxaficp_ir.c
@@ -820,9 +820,6 @@ static const struct net_device_ops pxa_irda_netdev_ops = {
.ndo_stop = pxa_irda_stop,
.ndo_start_xmit = pxa_irda_hard_xmit,
.ndo_do_ioctl = pxa_irda_ioctl,
- .ndo_change_mtu = eth_change_mtu,
- .ndo_validate_addr = eth_validate_addr,
- .ndo_set_mac_address = eth_mac_addr,
};
static int pxa_irda_probe(struct platform_device *pdev)
@@ -847,6 +844,7 @@ static int pxa_irda_probe(struct platform_device *pdev)
if (!dev)
goto err_mem_3;
+ SET_NETDEV_DEV(dev, &pdev->dev);
si = netdev_priv(dev);
si->dev = &pdev->dev;
si->pdata = pdev->dev.platform_data;
--
1.6.3.3
next prev parent reply other threads:[~2009-08-24 4:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200907240257.10906.marek.vasut@gmail.com>
2009-07-28 3:01 ` [PATCH] pxaficp-ir - remove incorrect net_device_ops Eric Miao
2009-07-29 11:16 ` Alexander Beregalov
2009-08-05 14:02 ` Marek Vasut
2009-08-21 22:54 ` Marek Vasut
2009-08-21 22:54 ` Marek Vasut
2009-08-23 17:55 ` Alexander Beregalov
2009-08-23 17:55 ` Alexander Beregalov
2009-08-24 1:49 ` David Miller
2009-08-24 1:49 ` David Miller
2009-08-24 4:38 ` Alexander Beregalov [this message]
2009-08-24 4:38 ` Alexander Beregalov
2009-08-24 5:57 ` David Miller
2009-08-24 5:57 ` David Miller
2009-08-24 12:47 ` Marek Vasut
2009-08-24 12:47 ` Marek Vasut
2009-07-24 0:44 Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090824043831.GA2473@orion \
--to=a.beregalov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.