[PATCH] base.bbclass: Replace os.system with subprocess call.

[PATCH] base.bbclass: Replace os.system with subprocess call.

[Khem Raj]

Often gzip is reporting broken pipe errors with do_unpack of
tar.gz files.

If you use the commands described above to extract a tar.gz file, gzip
sometimes emits a Broken pipe error message. This can safely be ignored
if tar extracted all files without any other error message.

We do not let python install its SIGPIPE handler and use subprocess call
to invoke the command.

This is based on the following python bug report.
http://bugs.python.org/issue1652

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 classes/base.bbclass |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/classes/base.bbclass b/classes/base.bbclass
index 598a7bb..4e9b65c 100644
--- a/classes/base.bbclass
+++ b/classes/base.bbclass
@@ -728,9 +728,14 @@ base_do_buildall() {
 	:
 }
 
+def subprocess_setup():
+	import signal, subprocess
+	# Python installs a SIGPIPE handler by default. This is usually not what
+	# non-Python subprocesses expect.
+	signal.signal(signal.SIGPIPE, signal.SIG_DFL)
 
 def oe_unpack_file(file, data, url = None):
-	import bb, os
+	import bb, os, signal, subprocess
 	if not url:
 		url = "file://%s" % file
 	dots = file.split(".")
@@ -799,7 +804,7 @@ def oe_unpack_file(file, data, url = None):
 
 	cmd = "PATH=\"%s\" %s" % (bb.data.getVar('PATH', data, 1), cmd)
 	bb.note("Unpacking %s to %s/" % (base_path_out(file, data), base_path_out(os.getcwd(), data)))
-	ret = os.system(cmd)
+	ret = subprocess.call(cmd, preexec_fn=subprocess_setup, shell=True)
 
 	os.chdir(save_cwd)
 
-- 
1.6.3.3

Re: [PATCH] base.bbclass: Replace os.system with subprocess call.

[Holger Hans Peter Freyther]

On Monday 24 August 2009 04:31:41 Khem Raj wrote:

> This is based on the following python bug report.
> http://bugs.python.org/issue1652

What about giving credit to the guy on irc that:
	- Pointed you to the gzip faq
	- The launchpad ticket
	- The blogpost
	- And the above URL?

z.

Re: [PATCH] base.bbclass: Replace os.system with subprocess call.

[Holger Hans Peter Freyther]

On Monday 24 August 2009 04:31:41 Khem Raj wrote:
> Often gzip is reporting broken pipe errors with do_unpack of
> tar.gz files.
>
> If you use the commands described above to extract a tar.gz file, gzip
> sometimes emits a Broken pipe error message. This can safely be ignored
> if tar extracted all files without any other error message.
>
> We do not let python install its SIGPIPE handler and use subprocess call
> to invoke the command.
>
> This is based on the following python bug report.
> http://bugs.python.org/issue1652
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Acked-by: Holger Freyther <zecke@selfish.org>


> ---
>  classes/base.bbclass |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/classes/base.bbclass b/classes/base.bbclass
> index 598a7bb..4e9b65c 100644
> --- a/classes/base.bbclass
> +++ b/classes/base.bbclass
> @@ -728,9 +728,14 @@ base_do_buildall() {
>
>  }
>
> +def subprocess_setup():
> +	import signal, subprocess
> +	# Python installs a SIGPIPE handler by default. This is usually not what
> +	# non-Python subprocesses expect.
> +	signal.signal(signal.SIGPIPE, signal.SIG_DFL)

you don't need to import subprocess here...



>
>  def oe_unpack_file(file, data, url = None):
> -	import bb, os
> +	import bb, os, signal, subprocess

no need for import signal...


>  	if not url:
>  		url = "file://%s" % file
>  	dots = file.split(".")
> @@ -799,7 +804,7 @@ def oe_unpack_file(file, data, url = None):
>
>  	cmd = "PATH=\"%s\" %s" % (bb.data.getVar('PATH', data, 1), cmd)
>  	bb.note("Unpacking %s to %s/" % (base_path_out(file, data),
> base_path_out(os.getcwd(), data))) -	ret = os.system(cmd)
> +	ret = subprocess.call(cmd, preexec_fn=subprocess_setup, shell=True)
>
>  	os.chdir(save_cwd)

Re: [PATCH] base.bbclass: Replace os.system with subprocess call.

[Khem Raj]

On (24/08/09 05:12), Holger Hans Peter Freyther wrote:
> On Monday 24 August 2009 04:31:41 Khem Raj wrote:
> 
> > This is based on the following python bug report.
> > http://bugs.python.org/issue1652
> 
> What about giving credit to the guy on irc that:

indeed. I should edit the git emails before sending them out.

> 	- Pointed you to the gzip faq
> 	- The launchpad ticket
> 	- The blogpost
> 	- And the above URL?

All of above Zecke's courtesy :) I can put this in git log too before
pushing.

> 
> z.
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [PATCH] base.bbclass: Replace os.system with subprocess call.

[Michael 'Mickey' Lauer]

As a general reminder, please avoid import statements in functions. They're 
just wasting cycles. Put them into global scope.

:M:

Re: [PATCH] base.bbclass: Replace os.system with subprocess call.

[Khem Raj]

On Sun, Aug 23, 2009 at 11:48 PM, Michael 'Mickey'
Lauer<mickey@vanille-media.de> wrote:
> As a general reminder, please avoid import statements in functions. They're
> just wasting cycles. Put them into global scope.

OK. I will redo this part.

>
> :M:
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] base.bbclass: Replace os.system with subprocess call.

[Richard Purdie]

On Mon, 2009-08-24 at 05:49 +0200, Holger Hans Peter Freyther wrote:
> On Monday 24 August 2009 04:31:41 Khem Raj wrote:
> > Often gzip is reporting broken pipe errors with do_unpack of
> > tar.gz files.
> >
> > If you use the commands described above to extract a tar.gz file, gzip
> > sometimes emits a Broken pipe error message. This can safely be ignored
> > if tar extracted all files without any other error message.
> >
> > We do not let python install its SIGPIPE handler and use subprocess call
> > to invoke the command.
> >
> > This is based on the following python bug report.
> > http://bugs.python.org/issue1652
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> 
> Acked-by: Holger Freyther <zecke@selfish.org>

Thanks, I've been seeing reports of this and have just merged into
Poky! :)

Cheers,

Richard

Re: [PATCH] base.bbclass: Replace os.system with subprocess call.

[Khem Raj]

On (24/08/09 08:48), Michael 'Mickey' Lauer wrote:
> As a general reminder, please avoid import statements in functions. They're 
> just wasting cycles. Put them into global scope.

looking at base.bbclass I decided to leave it as it is to conform to
other functions coding style but may be we should move the import to
global scope at once sometime.

Thanks

-Khem

> 
> :M:
> 
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel