Re: [Patch] libcldc,cldcli: Use humanized error messages

[Pete Zaitcev <zaitcev@redhat.com>]

On Wed, 26 Aug 2009 22:26:50 -0400, Jeff Garzik <jeff@garzik.org> wrote:
> On 08/26/2009 10:06 PM, Pete Zaitcev wrote:

> > Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
> 
> applied a modified version, see attached...  after that short IRC 
> discussion, I think an array with a range check would be nicer than 
> coding it (though the C compiler should make a nice, efficient table 
> from 'switch' statement for us...)

I don't think it's enough. Look:

+static const char *cld_errlist[] =
+{
+	[CLE_OK]		= "Success",
+	[CLE_SESS_EXISTS]	= "Session exists",

When you do indexed initializations, it's possible to create
empty array elements (currently there are none because indexes
are contiguous). So, the following needs a NULL check:

+	return cld_errlist[ecode];
+}

-- Pete