From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@elte.hu, linux-mm@kvack.org,
akpm@linux-foundation.org, hpa@zytor.com,
gregory.haskins@gmail.com
Subject: Re: [PATCHv4 2/2] vhost_net: a kernel-level virtio server
Date: Thu, 27 Aug 2009 19:29:22 +0930 [thread overview]
Message-ID: <200908271929.23454.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090826165655.GA23632@redhat.com>
On Thu, 27 Aug 2009 02:26:55 am Michael S. Tsirkin wrote:
> On Tue, Aug 25, 2009 at 04:16:34PM +0300, Michael S. Tsirkin wrote:
> > > > + /* If they don't want an interrupt, don't send one, unless empty. */
> > > > + if ((flags & VRING_AVAIL_F_NO_INTERRUPT) && vq->inflight)
> > > > + return;
> > >
> > > And I wouldn't support notify on empty at all, TBH.
> >
> > If I don't, virtio net in guest uses a timer, which might be expensive.
> > Will need to check what this does.
> >
> > > It should
> > > definitely be conditional on the guest accepting the NOTIFY_ON_EMPTY
> > > feature.
>
> lguest does not do it this way though, do it?
Does when a patch in my current queue is applied though.
Thanks,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@elte.hu, linux-mm@kvack.org,
akpm@linux-foundation.org, hpa@zytor.com,
gregory.haskins@gmail.com
Subject: Re: [PATCHv4 2/2] vhost_net: a kernel-level virtio server
Date: Thu, 27 Aug 2009 19:29:22 +0930 [thread overview]
Message-ID: <200908271929.23454.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090826165655.GA23632@redhat.com>
On Thu, 27 Aug 2009 02:26:55 am Michael S. Tsirkin wrote:
> On Tue, Aug 25, 2009 at 04:16:34PM +0300, Michael S. Tsirkin wrote:
> > > > + /* If they don't want an interrupt, don't send one, unless empty. */
> > > > + if ((flags & VRING_AVAIL_F_NO_INTERRUPT) && vq->inflight)
> > > > + return;
> > >
> > > And I wouldn't support notify on empty at all, TBH.
> >
> > If I don't, virtio net in guest uses a timer, which might be expensive.
> > Will need to check what this does.
> >
> > > It should
> > > definitely be conditional on the guest accepting the NOTIFY_ON_EMPTY
> > > feature.
>
> lguest does not do it this way though, do it?
Does when a patch in my current queue is applied though.
Thanks,
Rusty.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-08-27 9:59 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1250693417.git.mst@redhat.com>
2009-08-19 15:02 ` [PATCHv4 1/2] mm: export use_mm/unuse_mm to modules Michael S. Tsirkin
2009-08-19 15:02 ` Michael S. Tsirkin
2009-08-19 15:02 ` Michael S. Tsirkin
2009-08-19 15:02 ` Michael S. Tsirkin
2009-08-19 15:03 ` [PATCHv4 2/2] vhost_net: a kernel-level virtio server Michael S. Tsirkin
2009-08-19 15:03 ` Michael S. Tsirkin
2009-08-19 15:03 ` Michael S. Tsirkin
2009-08-25 12:10 ` Rusty Russell
2009-08-25 12:10 ` Rusty Russell
2009-08-25 12:10 ` Rusty Russell
2009-08-25 13:16 ` Michael S. Tsirkin
2009-08-25 13:16 ` Michael S. Tsirkin
2009-08-25 13:16 ` Michael S. Tsirkin
2009-08-26 16:56 ` Michael S. Tsirkin
2009-08-26 16:56 ` Michael S. Tsirkin
2009-08-27 9:59 ` Rusty Russell [this message]
2009-08-27 9:59 ` Rusty Russell
2009-08-27 9:59 ` Rusty Russell
2009-08-26 16:56 ` Michael S. Tsirkin
2009-08-25 17:50 ` Michael S. Tsirkin
2009-08-25 17:50 ` Michael S. Tsirkin
2009-08-26 13:40 ` Arnd Bergmann
2009-08-26 13:40 ` Arnd Bergmann
2009-08-26 13:40 ` Arnd Bergmann
2009-08-26 13:58 ` Michael S. Tsirkin
2009-08-26 13:58 ` Michael S. Tsirkin
2009-08-26 13:58 ` Michael S. Tsirkin
2009-08-27 10:10 ` Michael S. Tsirkin
2009-08-27 10:10 ` Michael S. Tsirkin
2009-08-27 11:03 ` Rusty Russell
2009-08-27 11:03 ` Rusty Russell
2009-08-27 11:03 ` Rusty Russell
2009-08-27 10:10 ` Michael S. Tsirkin
2009-08-25 17:50 ` Michael S. Tsirkin
2009-08-27 10:45 ` Michael S. Tsirkin
2009-08-27 10:45 ` Michael S. Tsirkin
2009-08-27 11:10 ` Rusty Russell
2009-08-27 11:10 ` Rusty Russell
2009-08-27 11:10 ` Rusty Russell
2009-08-27 11:19 ` Michael S. Tsirkin
2009-08-27 11:19 ` Michael S. Tsirkin
2009-08-27 11:19 ` Michael S. Tsirkin
2009-08-27 10:45 ` Michael S. Tsirkin
2009-08-19 15:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908271929.23454.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=gregory.haskins@gmail.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.