All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: adds mlogs to aops.c -V3
Date: Fri, 28 Aug 2009 00:34:00 -0700	[thread overview]
Message-ID: <20090828073359.GC19658@mail.oracle.com> (raw)
In-Reply-To: <4A978098.60306@oracle.com>

On Fri, Aug 28, 2009 at 03:00:40PM +0800, Wengang Wang wrote:
> >> and for the patch its self, I think the log contents are for developers 
> >> to check(not for customer to view), so we can know what are printed by 
> >> checking the src... so I am printing some parameters without pointing 
> >> out what they are.
> > 
> > 	Yeah, I just don't know that we care :-
> Oh, excuse for my poor English :P, what do you mean here?
> you think it's OK that we don't point out what are printed? or you think 
> we should point them out exactly in log contents?

	Sunil is right that developers will know what was printed and
that we don't need to be terribly detailed about that.  I'm saying that
I don't know that entry/exit logs are useful.  We never turn them on
because they are too noisy.

Joel

-- 

Life's Little Instruction Book #337

	"Reread your favorite book."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

  reply	other threads:[~2009-08-28  7:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-14  6:02 [Ocfs2-devel] [PATCH] ocfs2: adds mlogs to aops.c -V3 Wengang Wang
2009-08-28  1:10 ` Joel Becker
2009-08-28  2:12   ` Wengang Wang
2009-08-28  5:39     ` Joel Becker
2009-08-28  7:00       ` Wengang Wang
2009-08-28  7:34         ` Joel Becker [this message]
2009-08-28  7:40           ` Wengang Wang
2009-08-28  8:14             ` Joel Becker
2009-08-28 21:49             ` Joel Becker
2009-08-31  0:51               ` Wengang Wang
2009-08-28  7:41           ` Tao Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090828073359.GC19658@mail.oracle.com \
    --to=joel.becker@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.