From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: adds mlogs to aops.c -V3
Date: Fri, 28 Aug 2009 01:14:52 -0700 [thread overview]
Message-ID: <20090828081451.GD19658@mail.oracle.com> (raw)
In-Reply-To: <4A9789E5.9090205@oracle.com>
On Fri, Aug 28, 2009 at 03:40:21PM +0800, Wengang Wang wrote:
> Joel Becker wrote:
> > Sunil is right that developers will know what was printed and
> > that we don't need to be terribly detailed about that. I'm saying that
> > I don't know that entry/exit logs are useful. We never turn them on
> > because they are too noisy.
>
>
> Ok. Then I will pick up the mlog_error()s and mlog(ERR...)s and re-post
> later...
Yes, that would be great. Any time you are debugging some code
and you think "I'd really like to know this value here" or something,
feel free to add an mlog and send it in. We appreciate it. It's just
the entry/exit stuff we're trying to get away from.
(Of course, if you want to start the migration to the new
generic tracepoints...)
Thanks!
Joel
--
"The first thing we do, let's kill all the lawyers."
-Henry VI, IV:ii
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2009-08-28 8:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 6:02 [Ocfs2-devel] [PATCH] ocfs2: adds mlogs to aops.c -V3 Wengang Wang
2009-08-28 1:10 ` Joel Becker
2009-08-28 2:12 ` Wengang Wang
2009-08-28 5:39 ` Joel Becker
2009-08-28 7:00 ` Wengang Wang
2009-08-28 7:34 ` Joel Becker
2009-08-28 7:40 ` Wengang Wang
2009-08-28 8:14 ` Joel Becker [this message]
2009-08-28 21:49 ` Joel Becker
2009-08-31 0:51 ` Wengang Wang
2009-08-28 7:41 ` Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090828081451.GD19658@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.