From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Compiler warning in grub_cmdline_get
Date: Fri, 28 Aug 2009 14:48:45 +0200 [thread overview]
Message-ID: <20090828124845.GD15030@thorin> (raw)
In-Reply-To: <20090826235518.GV11691@riva.ucam.org>
On Thu, Aug 27, 2009 at 12:55:18AM +0100, Colin Watson wrote:
> I don't think this can actually cause a real problem, but it's a
> compiler warning since it might (e.g. if prompt ever contained "%").
>
> /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c: In function ‘grub_cmdline_get’:
> /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c:276: warning: format not a string literal and no format arguments
>
> 2009-08-27 Colin Watson <cjwatson@ubuntu.com>
>
> * normal/cmdline.c (grub_cmdline_get): Supply a format string as
> the first argument to grub_printf.
Thanks Colin. For obvious fixes like this one, feel free to commit them
right away.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-08-28 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 23:55 [PATCH] Compiler warning in grub_cmdline_get Colin Watson
2009-08-28 12:48 ` Robert Millan [this message]
2009-08-28 13:25 ` Colin Watson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090828124845.GD15030@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.