From: Christoph Hellwig <hch@lst.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] block: use fdatasync instead of fsync
Date: Tue, 1 Sep 2009 18:04:09 +0200 [thread overview]
Message-ID: <20090901160409.GA22629@lst.de> (raw)
In-Reply-To: <f43fc5580909010859n138c4b06jfdd9a4a6277b7f92@mail.gmail.com>
On Tue, Sep 01, 2009 at 06:59:46PM +0300, Blue Swirl wrote:
> On Mon, Aug 31, 2009 at 11:17 PM, Christoph Hellwig<hch@lst.de> wrote:
> >
> > If we are flushing the caches for our image files we only care about the
> > data (including the metadata required for accessing it) but not things
> > like timestamp updates. ??So use fdatasync instead of fsync to implement
> > the flush operations.
>
> > - ?? ??fsync(s->fd);
> > + ?? ??fdatasync(s->fd);
>
> There is no fdatasync outside of Linux, not in OpenBSD and mingw32 at
> least. But you could add a probe for it to configure.
Oh, okay. Kinda sad that people still don't implement useful inteface
that have been in Posix for a long time.
next prev parent reply other threads:[~2009-09-01 16:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 20:16 [Qemu-devel] [PATCH 0/4] data integrity fixes Christoph Hellwig
2009-08-31 20:16 ` [Qemu-devel] [PATCH 1/4] block: add enable_write_cache flag Christoph Hellwig
2009-08-31 22:09 ` Jamie Lokier
2009-08-31 22:16 ` Christoph Hellwig
2009-08-31 22:46 ` Jamie Lokier
2009-08-31 23:06 ` Christoph Hellwig
2009-09-01 10:38 ` Jamie Lokier
2009-08-31 22:53 ` Anthony Liguori
2009-08-31 22:55 ` Jamie Lokier
2009-08-31 22:58 ` Christoph Hellwig
2009-08-31 22:59 ` Jamie Lokier
2009-08-31 23:06 ` Christoph Hellwig
2009-08-31 23:09 ` Christoph Hellwig
2009-09-02 3:53 ` Christoph Hellwig
2009-09-02 13:13 ` Anthony Liguori
2009-09-02 14:14 ` Christoph Hellwig
2009-09-02 19:49 ` Christoph Hellwig
2009-08-31 20:17 ` [Qemu-devel] [PATCH 2/4] block: use fdatasync instead of fsync Christoph Hellwig
2009-08-31 21:51 ` Jamie Lokier
2009-08-31 21:55 ` Christoph Hellwig
2009-08-31 22:48 ` Jamie Lokier
2009-08-31 22:57 ` Christoph Hellwig
2009-09-01 15:59 ` Blue Swirl
2009-09-01 16:04 ` Christoph Hellwig [this message]
2009-09-02 0:34 ` Jamie Lokier
2009-09-02 0:37 ` Christoph Hellwig
2009-09-02 1:18 ` Jamie Lokier
2009-09-02 14:02 ` Blue Swirl
2009-09-02 14:15 ` Christoph Hellwig
2009-08-31 20:17 ` [Qemu-devel] [PATCH 3/4] block: add bdrv_aio_flush operation Christoph Hellwig
2009-09-01 10:24 ` Avi Kivity
2009-09-01 14:25 ` Christoph Hellwig
2009-08-31 20:18 ` [Qemu-devel] [PATCH 4/4] virtio-blk: add volatile writecache feature Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901160409.GA22629@lst.de \
--to=hch@lst.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.