From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Some documentation updates
Date: Wed, 2 Sep 2009 10:30:09 +0100 [thread overview]
Message-ID: <20090902093008.GQ13423@riva.ucam.org> (raw)
In-Reply-To: <d7ead6de0909020213l36d1eb9cu42b91078689d0fe6@mail.gmail.com>
On Wed, Sep 02, 2009 at 11:13:19AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Wed, Sep 2, 2009 at 11:06 AM, Colin Watson<cjwatson@ubuntu.com> wrote:
> > I'm afraid I temporarily ran out of steam at this point, so there are
> > still lots of commands to go, but here's a start. Does this look OK?
> >
> > 2009-09-02 Colin Watson <cjwatson@ubuntu.com>
> >
> > * docs/grub.texi: Describe one-based partition numbering.
> > Document acpi, blocklist, crc, export, insmod, keystatus, ls,
> > set, and unset commands.
>
> Could you perhaps explicitly mention sections updated?
Sure.
> > -example is @samp{(hd0,0)/boot/grub/menu.lst}. This means the file
> > +example is @samp{(hd0,1)/boot/grub/menu.lst}. This means the file
> > @file{/boot/grub/menu.lst} in the first partition of the first hard
>
> Please remove references to menu.lst. It's not wrong in this context
> but still confusing
OK.
> Other than this patch is good. I don't think it needs more review. You
> can commit it.
All right, thanks. Committed.
--
Colin Watson [cjwatson@ubuntu.com]
next prev parent reply other threads:[~2009-09-02 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 9:06 [PATCH] Some documentation updates Colin Watson
2009-09-02 9:13 ` Vladimir 'phcoder' Serbinenko
2009-09-02 9:30 ` Colin Watson [this message]
2009-09-03 14:30 ` Robert Millan
2009-09-03 14:51 ` Colin Watson
2009-09-03 18:49 ` Jordi Mallach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902093008.GQ13423@riva.ucam.org \
--to=cjwatson@ubuntu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.