From: Theodore Tso <tytso@mit.edu>
To: Andreas Dilger <adilger@sun.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsprogs: remove misleading argument from ext2fs_bg_flags_clear
Date: Wed, 2 Sep 2009 19:42:43 -0400 [thread overview]
Message-ID: <20090902234243.GC30497@mit.edu> (raw)
In-Reply-To: <20090902232811.GG4197@webber.adilger.int>
On Wed, Sep 02, 2009 at 05:28:11PM -0600, Andreas Dilger wrote:
> On Sep 02, 2009 16:43 -0500, Eric Sandeen wrote:
> > ext2fs_bg_flags_clear shouldn't take an unused bg_flags argument
> > if its purpose is to clear -all- flags. That just makes people
> > like me call it for the wrong purpose ;)
>
> I'd pointed this out when the code was originally submitted.
> That said, I'd prefer a function which allows clearing
> individual flags, rather than all of them. It is possible to
> call it with ~0 to clear all of the flags.
Agreed; if we want to have a function which clears all of the flags,
it should be named something like ext2fs_bg_flags_zap(), or some such.
It would be confusing for ext2fs_bg_flags_clear() and
ext2fs_bg_flags_set() not to be symmetric.
- Ted
next prev parent reply other threads:[~2009-09-02 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 21:43 [PATCH] e2fsprogs: remove misleading argument from ext2fs_bg_flags_clear Eric Sandeen
2009-09-02 23:28 ` Andreas Dilger
2009-09-02 23:42 ` Theodore Tso [this message]
2009-09-03 3:00 ` Eric Sandeen
2009-09-03 5:12 ` Andreas Dilger
2009-09-03 5:13 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902234243.GC30497@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.