All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Andreas Dilger <adilger@sun.com>
Cc: Theodore Tso <tytso@mit.edu>,
	ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsprogs: remove misleading argument from	ext2fs_bg_flags_clear
Date: Thu, 03 Sep 2009 00:13:52 -0500	[thread overview]
Message-ID: <4A9F5090.40406@redhat.com> (raw)
In-Reply-To: <20090903051235.GL4197@webber.adilger.int>

Andreas Dilger wrote:
> On Sep 02, 2009  22:00 -0500, Eric Sandeen wrote:
>> What about perhaps just these 3:
>>
>> ext2fs_bg_flags_zero(fs, group) /* zeros bg_flags */
>>
>> ext2fs_bg_flags_set(fs, group, flags) /* adds flags to bg_flags */
>> ext2fs_bg_flags_clear(fs, group, flags) /* clears flags in bg_flags */
>>
>> and remove the original ext2fs_bg_flags_set / ext2fs_bg_flags_clear.
> 
> Yes, this is exactly what I would expect from this kind of interface.

Ok, I'll try to get that sent out tomorrow, and any other similar 
interfaces.

Thanks,
-Eric

      reply	other threads:[~2009-09-03  5:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-02 21:43 [PATCH] e2fsprogs: remove misleading argument from ext2fs_bg_flags_clear Eric Sandeen
2009-09-02 23:28 ` Andreas Dilger
2009-09-02 23:42   ` Theodore Tso
2009-09-03  3:00     ` Eric Sandeen
2009-09-03  5:12       ` Andreas Dilger
2009-09-03  5:13         ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9F5090.40406@redhat.com \
    --to=sandeen@redhat.com \
    --cc=adilger@sun.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.