From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Cc: Pavel Roskin <proski@gnu.org>
Subject: Re: [PATCH] save_env variable_name=value
Date: Thu, 3 Sep 2009 17:08:59 +0200 [thread overview]
Message-ID: <20090903150859.GA18316@thorin> (raw)
In-Reply-To: <20090903145243.GZ13423@riva.ucam.org>
On Thu, Sep 03, 2009 at 03:52:43PM +0100, Colin Watson wrote:
> On Thu, Sep 03, 2009 at 04:33:23PM +0200, Robert Millan wrote:
> > On Wed, Sep 02, 2009 at 12:01:42PM +0100, Colin Watson wrote:
> > > 2009-09-02 Colin Watson <cjwatson@ubuntu.com>
> > >
> > > * commands/loadenv.c (grub_cmd_save_env): Allow an optional
> > > explicit value (`save_env variable_name=value').
> > > (GRUB_MOD_INIT (loadenv)): Update save_env summary.
> >
> > Maybe it is better to handle the extra logic at grub-mkconfig level
> > (for smaller/faster loadenv code). Is this feasible?
>
> It's feasible either way; I just did this because Pavel seemed to prefer
> it ...
Pavel, please comment on this when you can. It seems to me that doing it
in grub-mkconfig would require less ad-hoc code in loadenv.mod and make it
more efficient.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-09-03 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 11:01 [PATCH] save_env variable_name=value Colin Watson
2009-09-03 14:33 ` Robert Millan
2009-09-03 14:52 ` Colin Watson
2009-09-03 15:08 ` Robert Millan [this message]
2009-09-11 21:43 ` Pavel Roskin
2009-09-12 8:16 ` Colin Watson
2009-09-12 12:43 ` Robert Millan
2009-09-12 14:54 ` richardvoigt
2009-09-13 5:14 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903150859.GA18316@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.