From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Theodore Tso <tytso@mit.edu>,
Chris Mason <chris.mason@oracle.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: ext4 writepages is making tiny bios?
Date: Thu, 3 Sep 2009 12:42:09 -0400 [thread overview]
Message-ID: <20090903164209.GA28384@infradead.org> (raw)
In-Reply-To: <20090903055201.GA7146@discord.disaster>
On Thu, Sep 03, 2009 at 03:52:01PM +1000, Dave Chinner wrote:
> > XFS did the mistake of trusting the VM, while everyone more or less
> > overrode it. Removing all those checks and writing out much larger
> > data fixes it with a relatively small patch:
> >
> > http://verein.lst.de/~hch/xfs/xfs-writeback-scaling
>
> Careful:
>
> - tloff = min(tlast, startpage->index + 64);
> + tloff = min(tlast, startpage->index + 8192);
>
> That will cause 64k page machines to try to write back 512MB at a
> time. This will re-introduce similar to the behaviour in sles9 where
> writeback would only terminate at the end of an extent (because the
> mapping end wasn't capped like above).
Pretty good point, any applies to all the different things we discussed
recently. Ted, should be maybe introduce a max_writeback_mb instead of
the max_writeback_pages in the VM, too?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Theodore Tso <tytso@mit.edu>,
xfs@oss.sgi.com, Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Chris Mason <chris.mason@oracle.com>
Subject: Re: ext4 writepages is making tiny bios?
Date: Thu, 3 Sep 2009 12:42:09 -0400 [thread overview]
Message-ID: <20090903164209.GA28384@infradead.org> (raw)
In-Reply-To: <20090903055201.GA7146@discord.disaster>
On Thu, Sep 03, 2009 at 03:52:01PM +1000, Dave Chinner wrote:
> > XFS did the mistake of trusting the VM, while everyone more or less
> > overrode it. Removing all those checks and writing out much larger
> > data fixes it with a relatively small patch:
> >
> > http://verein.lst.de/~hch/xfs/xfs-writeback-scaling
>
> Careful:
>
> - tloff = min(tlast, startpage->index + 64);
> + tloff = min(tlast, startpage->index + 8192);
>
> That will cause 64k page machines to try to write back 512MB at a
> time. This will re-introduce similar to the behaviour in sles9 where
> writeback would only terminate at the end of an extent (because the
> mapping end wasn't capped like above).
Pretty good point, any applies to all the different things we discussed
recently. Ted, should be maybe introduce a max_writeback_mb instead of
the max_writeback_pages in the VM, too?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-09-03 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 18:44 ext4 writepages is making tiny bios? Chris Mason
2009-09-01 20:57 ` Theodore Tso
2009-09-01 21:27 ` Christoph Hellwig
2009-09-02 0:17 ` Chris Mason
2009-09-03 5:52 ` Dave Chinner
2009-09-03 16:42 ` Christoph Hellwig [this message]
2009-09-03 16:42 ` Christoph Hellwig
2009-09-04 0:15 ` Theodore Tso
2009-09-04 0:15 ` Theodore Tso
2009-09-04 7:20 ` Jens Axboe
2009-09-04 7:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903164209.GA28384@infradead.org \
--to=hch@infradead.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.