From: Joel Becker <Joel.Becker@oracle.com>
To: Sunil Mushran <sunil.mushran@oracle.com>
Cc: hch@infradead.org, viro@zeniv.linux.org.uk,
ocfs2-devel@oss.oracle.com, linux-fsdevel@kernel.org
Subject: [Ocfs2-devel] [PATCH 2/2] ocfs2: Use MAY_CREATE in ocfs2_permission()
Date: Thu, 3 Sep 2009 12:12:32 -0700 [thread overview]
Message-ID: <20090903191232.GA11525@mail.oracle.com> (raw)
In-Reply-To: <4A9F1FCB.5020406@oracle.com>
On Wed, Sep 02, 2009 at 06:45:47PM -0700, Sunil Mushran wrote:
> Joel Becker wrote:
> >@@ -1108,6 +1117,10 @@ int ocfs2_permission(struct inode *inode, int mask)
> > ret = generic_permission(inode, mask, ocfs2_check_acl);
> > ocfs2_inode_unlock(inode, 0);
> >+
> >+ if (mask & MAY_CREATE)
> >+ ocfs2_unblock_signals(&oldset);
> >+
> > out:
> > mlog_exit(ret);
> > return ret;
>
> Maybe I am missing something but shouldn't we be unblocking the signal
> after the out label.
Yes.
Joel
--
"Heav'n hath no rage like love to hatred turn'd, nor Hell a fury,
like a woman scorn'd."
- William Congreve
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Sunil Mushran <sunil.mushran@oracle.com>
Cc: hch@infradead.org, viro@zeniv.linux.org.uk,
ocfs2-devel@oss.oracle.com, linux-fsdevel@kernel.org
Subject: Re: [PATCH 2/2] ocfs2: Use MAY_CREATE in ocfs2_permission()
Date: Thu, 3 Sep 2009 12:12:32 -0700 [thread overview]
Message-ID: <20090903191232.GA11525@mail.oracle.com> (raw)
In-Reply-To: <4A9F1FCB.5020406@oracle.com>
On Wed, Sep 02, 2009 at 06:45:47PM -0700, Sunil Mushran wrote:
> Joel Becker wrote:
> >@@ -1108,6 +1117,10 @@ int ocfs2_permission(struct inode *inode, int mask)
> > ret = generic_permission(inode, mask, ocfs2_check_acl);
> > ocfs2_inode_unlock(inode, 0);
> >+
> >+ if (mask & MAY_CREATE)
> >+ ocfs2_unblock_signals(&oldset);
> >+
> > out:
> > mlog_exit(ret);
> > return ret;
>
> Maybe I am missing something but shouldn't we be unblocking the signal
> after the out label.
Yes.
Joel
--
"Heav'n hath no rage like love to hatred turn'd, nor Hell a fury,
like a woman scorn'd."
- William Congreve
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2009-09-03 19:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 1:06 [Ocfs2-devel] [PATCH 0/2] [RFC] Adding the MAY_CREATE flag to ->permission() Joel Becker
2009-09-03 1:06 ` Joel Becker
2009-09-03 1:06 ` [Ocfs2-devel] [PATCH 1/2] vfs: Add MAY_CREATE to the permission() flags Joel Becker
2009-09-03 1:06 ` Joel Becker
2009-09-03 1:06 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: Use MAY_CREATE in ocfs2_permission() Joel Becker
2009-09-03 1:06 ` Joel Becker
2009-09-03 1:45 ` [Ocfs2-devel] " Sunil Mushran
2009-09-03 1:45 ` Sunil Mushran
2009-09-03 19:12 ` Joel Becker [this message]
2009-09-03 19:12 ` Joel Becker
-- strict thread matches above, loose matches on Subject: below --
2009-10-14 9:57 [Ocfs2-devel] [PATCH 0/2] [RFC] Adding the MAY_CREATE flag to ->permission() Joel Becker
2009-10-14 9:57 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: Use MAY_CREATE in ocfs2_permission() Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903191232.GA11525@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sunil.mushran@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.