All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 5/5] Updating documentation accordingly
Date: Fri, 04 Sep 2009 15:45:13 +0000	[thread overview]
Message-ID: <20090904084513.8a35dc71.randy.dunlap@oracle.com> (raw)
In-Reply-To: <cb00fa210909011946g744a4f5cvbe6a2e7642eaa8ff@mail.gmail.com>

On Fri, 04 Sep 2009 09:25:11 -0300 Ivo Calado wrote:

> Updating documentation accordingly
> 
> Signed-off-by: Ivo Calado, Erivaldo Xavier, Leandro Sales
> <ivocalado@embedded.ufcg.edu.br>, <desadoc@gmail.com>,
> <leandroal@gmail.com>
> 
> Index: dccp_tree_work4/net/dccp/ccids/lib/loss_interval_sp.c
> =================================> --- dccp_tree_work4.orig/net/dccp/ccids/lib/loss_interval_sp.c
> 2009-09-04 00:28:03.000000000 -0300
> +++ dccp_tree_work4/net/dccp/ccids/lib/loss_interval_sp.c 2009-09-04
> 01:00:22.000000000 -0300
> @@ -324,7 +342,7 @@
> }
> 
> /**
> - * tfrc_lh_update_i_mean  -  Update the `open' loss interval I_0
> + * tfrc_sp_lh_update_i_mean  -  Update the `open' loss interval I_0
>   * This updates I_mean as the sequence numbers increase. As a
> consequence, the
>   * open loss interval I_0 increases, hence p = W_tot/max(I_tot0,
> I_tot1)
>   * decreases, and thus there is no need to send renewed feedback.
> @@ -372,7 +390,7 @@
> return cur->li_is_closed;
> }
> 
> -/** tfrc_lh_interval_add  -  Insert new record into the Loss Interval
> database
> +/** tfrc_sp_lh_interval_add - Insert new record into the Loss Interval
> database

The beginning kernel-doc marker ("/**") should be on a line by itself,
like all of the others are.


>   * @lh:    Loss Interval database
>   * @rh:    Receive history containing a fresh loss event
>   * @calc_first_li: Caller-dependent routine to compute length of first
> interval

> Index: dccp_tree_work4/net/dccp/ccids/lib/tfrc_equation_sp.c
> =================================> --- dccp_tree_work4.orig/net/dccp/ccids/lib/tfrc_equation_sp.c
> 2009-09-03 22:01:08.000000000 -0300
> +++ dccp_tree_work4/net/dccp/ccids/lib/tfrc_equation_sp.c 2009-09-04
> 00:54:05.000000000 -0300
> @@ -607,7 +609,7 @@
> }
> 
> /**
> - * tfrc_calc_x - Calculate the send rate as per section 3.1 of RFC3448
> + * tfrc_sp_calc_x - Calculate the send rate as per section 3.1 of
> RFC3448

Looks like some mail-handling software is splitting lines where they
should not be split.  You should check that the mailed patches (on the
receiving side) can be applied cleanly.


>   *
>   *  @s: packet size          in bytes
>   *  @R: RTT                  scaled by 1000000   (i.e., microseconds)



---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Ivo Calado <ivocalado@embedded.ufcg.edu.br>
Cc: dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] Updating documentation accordingly
Date: Fri, 4 Sep 2009 08:45:13 -0700	[thread overview]
Message-ID: <20090904084513.8a35dc71.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1252067111.6172.5.camel@localhost>

On Fri, 04 Sep 2009 09:25:11 -0300 Ivo Calado wrote:

> Updating documentation accordingly
> 
> Signed-off-by: Ivo Calado, Erivaldo Xavier, Leandro Sales
> <ivocalado@embedded.ufcg.edu.br>, <desadoc@gmail.com>,
> <leandroal@gmail.com>
> 
> Index: dccp_tree_work4/net/dccp/ccids/lib/loss_interval_sp.c
> ===================================================================
> --- dccp_tree_work4.orig/net/dccp/ccids/lib/loss_interval_sp.c
> 2009-09-04 00:28:03.000000000 -0300
> +++ dccp_tree_work4/net/dccp/ccids/lib/loss_interval_sp.c 2009-09-04
> 01:00:22.000000000 -0300
> @@ -324,7 +342,7 @@
> }
> 
> /**
> - * tfrc_lh_update_i_mean  -  Update the `open' loss interval I_0
> + * tfrc_sp_lh_update_i_mean  -  Update the `open' loss interval I_0
>   * This updates I_mean as the sequence numbers increase. As a
> consequence, the
>   * open loss interval I_0 increases, hence p = W_tot/max(I_tot0,
> I_tot1)
>   * decreases, and thus there is no need to send renewed feedback.
> @@ -372,7 +390,7 @@
> return cur->li_is_closed;
> }
> 
> -/** tfrc_lh_interval_add  -  Insert new record into the Loss Interval
> database
> +/** tfrc_sp_lh_interval_add - Insert new record into the Loss Interval
> database

The beginning kernel-doc marker ("/**") should be on a line by itself,
like all of the others are.


>   * @lh:    Loss Interval database
>   * @rh:    Receive history containing a fresh loss event
>   * @calc_first_li: Caller-dependent routine to compute length of first
> interval

> Index: dccp_tree_work4/net/dccp/ccids/lib/tfrc_equation_sp.c
> ===================================================================
> --- dccp_tree_work4.orig/net/dccp/ccids/lib/tfrc_equation_sp.c
> 2009-09-03 22:01:08.000000000 -0300
> +++ dccp_tree_work4/net/dccp/ccids/lib/tfrc_equation_sp.c 2009-09-04
> 00:54:05.000000000 -0300
> @@ -607,7 +609,7 @@
> }
> 
> /**
> - * tfrc_calc_x - Calculate the send rate as per section 3.1 of RFC3448
> + * tfrc_sp_calc_x - Calculate the send rate as per section 3.1 of
> RFC3448

Looks like some mail-handling software is splitting lines where they
should not be split.  You should check that the mailed patches (on the
receiving side) can be applied cleanly.


>   *
>   *  @s: packet size          in bytes
>   *  @R: RTT                  scaled by 1000000   (i.e., microseconds)



---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

  parent reply	other threads:[~2009-09-04 15:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-02  2:46 [PATCH 5/5] Updating documentation accordingly Ivo Calado
2009-09-02  2:46 ` Ivo Calado
2009-09-04 12:25 ` Ivo Calado
2009-09-04 12:25   ` Ivo Calado
2009-09-04 15:45 ` Randy Dunlap [this message]
2009-09-04 15:45   ` Randy Dunlap
2009-09-08 18:28 ` Ivo Calado
2009-09-08 18:28   ` Ivo Calado
2009-09-13 18:50 ` Gerrit Renker
2009-09-13 18:50   ` Gerrit Renker
2009-09-15  0:41 ` Ivo Calado
2009-09-15  0:41   ` Ivo Calado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090904084513.8a35dc71.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.