All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>,
	Fr??d??ric Weisbecker <fweisbec@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	jens.axboe@oracle.com
Subject: Re: [PATCH 0/2]: Get perf counters working on D-cache aliasing cpus.
Date: Tue, 8 Sep 2009 14:36:10 +0200	[thread overview]
Message-ID: <20090908123610.GA3515@elte.hu> (raw)
In-Reply-To: <20090908.051045.26522683.davem@davemloft.net>


* David Miller <davem@davemloft.net> wrote:

> With Jen's Axboe's basic sparc counter patch in my tree I started 
> playing with it on sparc64.  Turns out it won't work on anything 
> pre-Niagara.
> 
> The issue is D-cache aliasing between the kernel side mapping and 
> the user side mapping of the perf event ring buffer.
> 
> The following two patches attempt to address this issue and are 
> working properly on my test machine.

Oh, great!

The only (small) worry would be that this uses vmalloc space on 
32-bit platforms which is generally a scarce resource.

IMHO it's not a big issue as the typical workflow would be to have 
just a handful of perf ring-buffers around and most of the 
performance work happens in the 64-bit space anyway.

One practical complication is lots of tracepoints and perf trace: 
but we can solve that via output buffer multiplexing: 
PERF_COUNTER_IOC_SET_OUTPUT - which is implemented in 
tip:perfcounters/core but not yet propagated to the tools. That 
would be desirable to do anyway, to enable time-coherent trace 
entries, etc.

	Ingo

  reply	other threads:[~2009-09-08 12:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-08 12:10 [PATCH 0/2]: Get perf counters working on D-cache aliasing cpus David Miller
2009-09-08 12:36 ` Ingo Molnar [this message]
2009-09-08 12:38   ` David Miller
2009-09-18 12:31 ` Peter Zijlstra
2009-09-18 17:22   ` David Miller
2009-09-18 17:26     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090908123610.GA3515@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.