From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Christoph Hellwig <hch@lst.de>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Zdenek Kabelac <zdenek.kabelac@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mmc@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: Regression in suspend to ram in 2.6.31-rc kernels
Date: Tue, 8 Sep 2009 21:48:33 +0200 [thread overview]
Message-ID: <200909082148.33872.rjw@sisk.pl> (raw)
In-Reply-To: <20090908190614.GA18545@lst.de>
On Tuesday 08 September 2009, Christoph Hellwig wrote:
> On Fri, Sep 04, 2009 at 09:47:46AM +0900, OGAWA Hirofumi wrote:
> > Well, that commit seems a bit strange. It calls fat_clusters_flush()
> > unconditionally without checking sb->s_dirt. However, if my guess is
> > right, "sync after removed event" itself sounds like the issue in
> > suspend process.
>
> The idea of ->sync_fs is that we always perform the sync activity,
> and not just the usual background superblock writeback trigerred by
> s_dirt. If FAT doesn't need that and never has races around s_dirt
> you can add the check back, but I would recommend against it.
>
> Also when you hack around this in FAt MMC will still fail with every
> other filesystem.
So, what should be done in your opinion?
Rafael
next prev parent reply other threads:[~2009-09-08 19:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 11:51 Regression in suspend to ram in 2.6.31-rc kernels Zdenek Kabelac
2009-08-31 19:19 ` Rafael J. Wysocki
2009-09-01 9:34 ` Zdenek Kabelac
2009-09-03 22:29 ` Zdenek Kabelac
2009-09-03 23:23 ` Christoph Hellwig
2009-09-04 0:47 ` OGAWA Hirofumi
2009-09-04 9:13 ` Zdenek Kabelac
2009-09-05 17:22 ` OGAWA Hirofumi
2009-09-05 19:53 ` Zdenek Kabelac
2009-09-05 22:42 ` OGAWA Hirofumi
2009-09-08 8:10 ` Zdenek Kabelac
2009-09-09 13:15 ` OGAWA Hirofumi
2009-09-07 12:51 ` Pavel Machek
2009-09-09 13:21 ` OGAWA Hirofumi
2009-09-10 19:23 ` Pavel Machek
2009-09-11 6:39 ` OGAWA Hirofumi
2009-09-11 20:09 ` Pavel Machek
2009-09-11 21:14 ` Zdenek Kabelac
2009-09-11 21:32 ` Pavel Machek
2009-09-11 21:45 ` Zdenek Kabelac
2009-09-11 21:51 ` Pavel Machek
2009-09-11 22:22 ` Rafael J. Wysocki
2009-09-14 20:05 ` Pierre Ossman
2009-09-14 20:25 ` Pavel Machek
2009-09-11 22:29 ` Chris Ball
2009-09-11 22:36 ` Rafael J. Wysocki
2009-09-14 8:39 ` Zdenek Kabelac
2009-09-14 19:17 ` Rafael J. Wysocki
2009-09-14 20:27 ` Pavel Machek
2009-09-18 11:15 ` OGAWA Hirofumi
2009-09-18 21:39 ` Rafael J. Wysocki
2009-09-11 22:22 ` Chris Ball
2009-09-11 22:04 ` Rafael J. Wysocki
2009-09-11 22:21 ` Pavel Machek
2009-09-11 22:32 ` Rafael J. Wysocki
2009-09-08 19:06 ` Christoph Hellwig
2009-09-08 19:48 ` Rafael J. Wysocki [this message]
2009-09-09 13:52 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909082148.33872.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=hch@lst.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.