From: Bob Copeland <me@bobcopeland.com>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lrodriguez@atheros.com, mickflemm@gmail.com, jirislaby@gmail.com,
linville@tuxdriver.com, johannes@sipsolutions.net
Subject: Re: [PATCH] ath5k: do not free irq after resume when card has been removed
Date: Tue, 8 Sep 2009 23:32:37 -0400 [thread overview]
Message-ID: <20090909033237.GC13550@hash.localnet> (raw)
In-Reply-To: <1252457551-4909-1-git-send-email-cascardo@holoscopio.com>
On Tue, Sep 08, 2009 at 09:52:31PM -0300, Thadeu Lima de Souza Cascardo wrote:
> ath5k will try to request irq when resuming and fails if the device
> (like a PCMCIA card) has been removed.
That's not true, ath5k no longer requests an irq when resuming.
> This solves this issue defining a new flag for the status bitmap to
> indicate when irq has been successfully requested and does not try to
> release it if not.
I'd rather not fix it with a status bit. What kernel is this against?
--
Bob Copeland %% www.bobcopeland.com
WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me@bobcopeland.com>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: ath5k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lrodriguez@atheros.com, mickflemm@gmail.com, jirislaby@gmail.com,
linville@tuxdriver.com, johannes@sipsolutions.net
Subject: Re: [PATCH] ath5k: do not free irq after resume when card has been removed
Date: Tue, 8 Sep 2009 23:32:37 -0400 [thread overview]
Message-ID: <20090909033237.GC13550@hash.localnet> (raw)
In-Reply-To: <1252457551-4909-1-git-send-email-cascardo@holoscopio.com>
On Tue, Sep 08, 2009 at 09:52:31PM -0300, Thadeu Lima de Souza Cascardo wrote:
> ath5k will try to request irq when resuming and fails if the device
> (like a PCMCIA card) has been removed.
That's not true, ath5k no longer requests an irq when resuming.
> This solves this issue defining a new flag for the status bitmap to
> indicate when irq has been successfully requested and does not try to
> release it if not.
I'd rather not fix it with a status bit. What kernel is this against?
--
Bob Copeland %% www.bobcopeland.com
WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me-aXfl/3sk2vNUbtYUoyoikg@public.gmane.org>
To: Thadeu Lima de Souza Cascardo
<cascardo-DmMZpsCg3uxeGPcbtGPokg@public.gmane.org>
Cc: ath5k-devel-xDcbHBWguxEUs3QNXV6qNA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lrodriguez-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org,
mickflemm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
jirislaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org
Subject: Re: [PATCH] ath5k: do not free irq after resume when card has been removed
Date: Tue, 8 Sep 2009 23:32:37 -0400 [thread overview]
Message-ID: <20090909033237.GC13550@hash.localnet> (raw)
In-Reply-To: <1252457551-4909-1-git-send-email-cascardo-DmMZpsCg3uxeGPcbtGPokg@public.gmane.org>
On Tue, Sep 08, 2009 at 09:52:31PM -0300, Thadeu Lima de Souza Cascardo wrote:
> ath5k will try to request irq when resuming and fails if the device
> (like a PCMCIA card) has been removed.
That's not true, ath5k no longer requests an irq when resuming.
> This solves this issue defining a new flag for the status bitmap to
> indicate when irq has been successfully requested and does not try to
> release it if not.
I'd rather not fix it with a status bit. What kernel is this against?
--
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-09-09 3:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 0:52 [PATCH] ath5k: do not free irq after resume when card has been removed Thadeu Lima de Souza Cascardo
2009-09-09 0:52 ` Thadeu Lima de Souza Cascardo
2009-09-09 3:32 ` Bob Copeland [this message]
2009-09-09 3:32 ` Bob Copeland
2009-09-09 3:32 ` Bob Copeland
2009-09-09 17:50 ` Thadeu Lima de Souza Cascardo
2009-09-09 17:50 ` Thadeu Lima de Souza Cascardo
2009-09-09 19:31 ` Bob Copeland
2009-09-09 19:31 ` Bob Copeland
2009-09-09 19:31 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090909033237.GC13550@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=cascardo@holoscopio.com \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=mickflemm@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.