Re: [PATCH 2/2] ksym_tracer: Remove KSYM_SELFTEST_ENTRY

[Frederic Weisbecker <fweisbec@gmail.com>]

On Thu, Sep 10, 2009 at 09:35:20AM +0800, Li Zefan wrote:
> The macro used to be used in both trace_selftest.c and
> trace_ksym.c, but no longer, so remove it from header file.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>



Steve, I should better take this one. I'm currently working
on the breakpoint tree and I prepare a pull request so I can
bring it inside.

Thanks.


> ---
>  kernel/trace/trace.h          |    1 -
>  kernel/trace/trace_selftest.c |    2 +-
>  2 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index 76ed0db..e6b1c73 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -202,7 +202,6 @@ struct syscall_trace_exit {
>  	unsigned long		ret;
>  };
>  
> -#define KSYM_SELFTEST_ENTRY "ksym_selftest_dummy"
>  extern int process_new_ksym_entry(char *ksymname, int op, unsigned long addr);
>  
>  struct ksym_trace_entry {
> diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
> index 7179c12..a006f00 100644
> --- a/kernel/trace/trace_selftest.c
> +++ b/kernel/trace/trace_selftest.c
> @@ -828,7 +828,7 @@ trace_selftest_startup_ksym(struct tracer *trace, struct trace_array *tr)
>  
>  	ksym_selftest_dummy = 0;
>  	/* Register the read-write tracing request */
> -	ret = process_new_ksym_entry(KSYM_SELFTEST_ENTRY, HW_BREAKPOINT_RW,
> +	ret = process_new_ksym_entry("ksym_selftest_dummy", HW_BREAKPOINT_RW,
>  					(unsigned long)(&ksym_selftest_dummy));
>  
>  	if (ret < 0) {
> -- 
> 1.6.3