* [PATCH 2/2] ksym_tracer: Remove KSYM_SELFTEST_ENTRY
@ 2009-09-10 1:35 Li Zefan
2009-09-10 1:48 ` Frederic Weisbecker
0 siblings, 1 reply; 3+ messages in thread
From: Li Zefan @ 2009-09-10 1:35 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Frederic Weisbecker, Ingo Molnar, LKML
The macro used to be used in both trace_selftest.c and
trace_ksym.c, but no longer, so remove it from header file.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/trace/trace.h | 1 -
kernel/trace/trace_selftest.c | 2 +-
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index 76ed0db..e6b1c73 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -202,7 +202,6 @@ struct syscall_trace_exit {
unsigned long ret;
};
-#define KSYM_SELFTEST_ENTRY "ksym_selftest_dummy"
extern int process_new_ksym_entry(char *ksymname, int op, unsigned long addr);
struct ksym_trace_entry {
diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
index 7179c12..a006f00 100644
--- a/kernel/trace/trace_selftest.c
+++ b/kernel/trace/trace_selftest.c
@@ -828,7 +828,7 @@ trace_selftest_startup_ksym(struct tracer *trace, struct trace_array *tr)
ksym_selftest_dummy = 0;
/* Register the read-write tracing request */
- ret = process_new_ksym_entry(KSYM_SELFTEST_ENTRY, HW_BREAKPOINT_RW,
+ ret = process_new_ksym_entry("ksym_selftest_dummy", HW_BREAKPOINT_RW,
(unsigned long)(&ksym_selftest_dummy));
if (ret < 0) {
--
1.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] ksym_tracer: Remove KSYM_SELFTEST_ENTRY
2009-09-10 1:35 [PATCH 2/2] ksym_tracer: Remove KSYM_SELFTEST_ENTRY Li Zefan
@ 2009-09-10 1:48 ` Frederic Weisbecker
2009-09-10 1:56 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Frederic Weisbecker @ 2009-09-10 1:48 UTC (permalink / raw)
To: Li Zefan, Steven Rostedt; +Cc: Ingo Molnar, LKML
On Thu, Sep 10, 2009 at 09:35:20AM +0800, Li Zefan wrote:
> The macro used to be used in both trace_selftest.c and
> trace_ksym.c, but no longer, so remove it from header file.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Steve, I should better take this one. I'm currently working
on the breakpoint tree and I prepare a pull request so I can
bring it inside.
Thanks.
> ---
> kernel/trace/trace.h | 1 -
> kernel/trace/trace_selftest.c | 2 +-
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index 76ed0db..e6b1c73 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -202,7 +202,6 @@ struct syscall_trace_exit {
> unsigned long ret;
> };
>
> -#define KSYM_SELFTEST_ENTRY "ksym_selftest_dummy"
> extern int process_new_ksym_entry(char *ksymname, int op, unsigned long addr);
>
> struct ksym_trace_entry {
> diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
> index 7179c12..a006f00 100644
> --- a/kernel/trace/trace_selftest.c
> +++ b/kernel/trace/trace_selftest.c
> @@ -828,7 +828,7 @@ trace_selftest_startup_ksym(struct tracer *trace, struct trace_array *tr)
>
> ksym_selftest_dummy = 0;
> /* Register the read-write tracing request */
> - ret = process_new_ksym_entry(KSYM_SELFTEST_ENTRY, HW_BREAKPOINT_RW,
> + ret = process_new_ksym_entry("ksym_selftest_dummy", HW_BREAKPOINT_RW,
> (unsigned long)(&ksym_selftest_dummy));
>
> if (ret < 0) {
> --
> 1.6.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] ksym_tracer: Remove KSYM_SELFTEST_ENTRY
2009-09-10 1:48 ` Frederic Weisbecker
@ 2009-09-10 1:56 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2009-09-10 1:56 UTC (permalink / raw)
To: Frederic Weisbecker; +Cc: Li Zefan, Ingo Molnar, LKML
On Thu, 2009-09-10 at 03:48 +0200, Frederic Weisbecker wrote:
> On Thu, Sep 10, 2009 at 09:35:20AM +0800, Li Zefan wrote:
> > The macro used to be used in both trace_selftest.c and
> > trace_ksym.c, but no longer, so remove it from header file.
> >
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
>
>
>
> Steve, I should better take this one. I'm currently working
> on the breakpoint tree and I prepare a pull request so I can
> bring it inside.
OK, I'll take patch 1, and you can take patch 2 ;-)
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-10 1:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-10 1:35 [PATCH 2/2] ksym_tracer: Remove KSYM_SELFTEST_ENTRY Li Zefan
2009-09-10 1:48 ` Frederic Weisbecker
2009-09-10 1:56 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.