From: Wolfram Sang <w.sang@pengutronix.de>
To: Heiko Schocher <hs@denx.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52
Date: Mon, 14 Sep 2009 10:03:23 +0200 [thread overview]
Message-ID: <20090914080322.GA3164@pengutronix.de> (raw)
In-Reply-To: <4AADF93C.3030604@denx.de>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
Hi,
> + mpc5200_pic: interrupt-controller@500 {
> + // 5200 interrupts are encoded into two levels;
Grant, maybe this comment could be dropped also for the in-kernel dts-files? I
think it is sufficently described in mpc5200.txt. I could prepare a patch if
you agree.
> + i2c@3d40 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,mpc5200-i2c","fsl-i2c";
> + reg = <0x3d40 0x40>;
> + interrupts = <2 16 0>;
> + fsl5200-clocking;
Please drop the clocking-line. It became obsolete.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-09-14 8:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 8:05 [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-09-14 8:03 ` Wolfram Sang [this message]
2009-09-14 14:09 ` Heiko Schocher
2009-09-14 14:45 ` Grant Likely
2009-10-05 7:46 ` [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101 Heiko Schocher
2009-10-05 9:53 ` Wolfram Sang
2009-10-05 10:12 ` Heiko Schocher
2009-10-05 13:46 ` Grant Likely
2009-10-06 5:19 ` Heiko Schocher
2009-10-06 8:06 ` Wolfram Sang
2009-10-07 6:40 ` [PATCH v3] " Heiko Schocher
2009-10-07 6:40 ` [PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-10-07 9:49 ` Wolfram Sang
2009-10-07 13:57 ` Grant Likely
2009-10-08 5:54 ` [PATCH v4] mpc5200: support for the MAN mpc5200 based board uc101 Heiko Schocher
2009-10-08 5:54 ` [PATCH v4] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-10-08 5:49 ` [PATCH v3] " Heiko Schocher
2009-10-05 7:46 ` [PATCH v2] " Heiko Schocher
2009-09-14 13:43 ` [PATCH] " Grant Likely
2009-09-14 14:32 ` Heiko Schocher
2009-09-14 14:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090914080322.GA3164@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=hs@denx.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.