Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

[Heiko Schocher <hs@denx.de>]

Hello Grant,

Grant Likely wrote:
> Comments below.
> 
> On Mon, Sep 14, 2009 at 2:05 AM, Heiko Schocher <hs@denx.de> wrote:
>> - serial Console on PSC1
>> - 64MB SDRAM
>> - MTD CFI Flash
>> - Ethernet FEC
>> - I2C with PCF8563 and Temp. Sensor ADM9240
>> - IDE support
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>
>>  arch/powerpc/boot/dts/mucmc52.dts            |  231 ++++
>>  arch/powerpc/configs/52xx/mucmc52_defconfig  | 1476 ++++++++++++++++++++++++++
> 
> Same comment as on your other patch.  Drop the defconfig and add the
> needed bits to mpc5200_defconfig (in a separate patch, and add drivers
> as modules).

Yep, thanks. I look, how this works.

>> diff --git a/arch/powerpc/boot/dts/mucmc52.dts b/arch/powerpc/boot/dts/mucmc52.dts
>> new file mode 100644
>> index 0000000..a4a7a20
>> --- /dev/null
>> +++ b/arch/powerpc/boot/dts/mucmc52.dts
>> @@ -0,0 +1,231 @@
>> +/*
>> + * mucmc52 board Device Tree Source
>> + *
>> + * Copyright (C) 2009 DENX Software Engineering GmbH
>> + * Heiko Schocher <hs@denx.de>
>> + *
>> + * This program is free software; you can redistribute  it and/or modify it
>> + * under  the terms of  the GNU General  Public License as published by the
>> + * Free Software Foundation;  either version 2 of the  License, or (at your
>> + * option) any later version.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +/ {
>> +       model = "man,mucmc52";
>> +       compatible = "man,mucmc52";
>> +       #address-cells = <1>;
>> +       #size-cells = <1>;
>> +       interrupt-parent = <&mpc5200_pic>;
>> +
>> +       cpus {
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +
>> +               PowerPC,5200@0 {
>> +                       device_type = "cpu";
>> +                       reg = <0>;
>> +                       d-cache-line-size = <32>;
>> +                       i-cache-line-size = <32>;
>> +                       d-cache-size = <0x4000>;        // L1, 16K
>> +                       i-cache-size = <0x4000>;        // L1, 16K
>> +                       timebase-frequency = <0>;       // from bootloader
>> +                       bus-frequency = <0>;            // from bootloader
>> +                       clock-frequency = <0>;          // from bootloader
>> +               };
>> +       };
>> +
>> +       memory {
>> +               device_type = "memory";
>> +               reg = <0x00000000 0x04000000>;  // 64MB
>> +       };
>> +
>> +       soc5200@f0000000 {
>> +               #address-cells = <1>;
>> +               #size-cells = <1>;
>> +               compatible = "fsl,mpc5200-immr";
> 
> Does this board use the older and rarer non-'B' mpc5200 part?  If not,
> then fsl,mpc5200b-immr also needs to be in this list.

OK, I add this too

Thanks

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany