From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: alsa-devel@alsa-project.org, Jassi <jassi.brar@samsung.com>,
ben@trinity.fluff.org
Subject: Re: [PATCH] S3C64XX I2S: Added machine driver for WM8580
Date: Thu, 17 Sep 2009 12:02:42 +0100 [thread overview]
Message-ID: <20090917110241.GC30736@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1253163253-10372-1-git-send-email-jassisinghbrar@gmail.com>
On Thu, Sep 17, 2009 at 01:54:13PM +0900, jassi brar wrote:
> + /* Exceptions for this CPU-CODEC combination */
> + case 64000:
> + rfs = 384;
> + break;
This needs to explain what the exceptions are for as well, otherwise
anyone working with the code is going to have to work it out from
scratch.
> +/* SMDK64xx Playback widgets */
> +static const struct snd_soc_dapm_widget wm8580_dapm_widgets_pbk[] = {
> + SND_SOC_DAPM_HP("Front-L/R", NULL),
> + SND_SOC_DAPM_HP("Center/Sub", NULL),
> + SND_SOC_DAPM_HP("Rear-L/R", NULL),
> +};
All my previous comments about these and the way they're being
configured still apply.
next prev parent reply other threads:[~2009-09-17 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 4:54 [PATCH] S3C64XX I2S: Added machine driver for WM8580 jassi brar
2009-09-17 11:02 ` Mark Brown [this message]
2009-09-17 11:35 ` jassi brar
2009-09-17 12:03 ` Mark Brown
2009-09-17 12:26 ` jassi brar
2009-09-17 13:11 ` Mark Brown
2009-09-17 13:36 ` jassi brar
2009-09-17 14:12 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2009-09-16 10:02 Jassi
2009-09-16 20:00 ` Mark Brown
2009-09-17 0:02 ` jassi brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090917110241.GC30736@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben@trinity.fluff.org \
--cc=jassi.brar@samsung.com \
--cc=jassisinghbrar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.