Re: [PATCH] S3C64XX I2S: Added machine driver for WM8580

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Thu, Sep 17, 2009 at 10:36:10PM +0900, jassi brar wrote:
> On Thu, Sep 17, 2009 at 10:11 PM, Mark Brown

> > Your comment says that only the output frequencies in table 52 are
> > supported.  Could you please provide more specific references to where
> > this is done in the driver?  I think you're confusing the fact that the
> > example table lists most of the common audio frequencies with what the
> > driver supports here.

> Let me be precise.
> With this machine driver and the WM8580 CODEC driver from origin/for-2.6.32
> if we do any of the following:-
>    snd_soc_dai_set_pll(codec_dai, WM8580_PLLA, 12000000, 8000*256);
>    snd_soc_dai_set_pll(codec_dai, WM8580_PLLA, 12000000, 11025*256);
>    snd_soc_dai_set_pll(codec_dai, WM8580_PLLA, 12000000, 64000*256);
> we get the error: "wm8580: Unable to scale output frequency"

Right, this is nothing to do with the list of example configurations and
everything to do with the fact that those options are just not supported
by the hardware.  For example, 256fs for 8kHz is only 2.048MHz and even
the largest postscale divider of 24 can't get anywhere near that from
90MHz which is the minimum Fvco for the PLL.

> I apologize if my inappropriate selection of expression bothered you.
> In future, please feel free to suggest modification of any comment in the
> code. Regards.

Part of the issue here is that my review is in part based on the
comments.  If the code (including comments) seems obviously incorrect
from reading then that's an issue in itself.