Re: [PATCH] Remove broken by design and by implementation devtmpfs maintenance disaster

[Greg KH <greg@kroah.com>]

On Thu, Sep 17, 2009 at 04:43:25PM +0100, Alan Cox wrote:
> > > I've seen nacks from Christoph and from Eric and it seems Al Viro has yet
> > > to review devtmpfs. I'd like to see Al's opinion personally.
> > 
> > That's fine, but as it's just using the standard tmpfs interfaces that
> > other in-kernel virtual filesystems use, it shouldn't need that much
> > review.  The code is quite small as well, and I thought Al was still on
> > an extended vacation.
> > 
> > This code has been reviewed and posted numerous times for over 6 months
> > now, which should be plenty of time for us to be waiting for a review,
> > don't you?
> 
> Christoph has already nacked the code and indicated some problems (albeit
> in his inimitably friendly fashion) so you had at least one review, you
> just apparently didn't like the answer.

No, he did not point out any technical problem with the code that I can
find.  I asked for details, but he's probably on a plane at the moment.
I'll see him in a few days, so we can discuss it there if needed.

thanks,

greg k-h