From: Andrew Morton <akpm@linux-foundation.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: tomaz.mertelj@guest.arnes.si, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments
Date: Mon, 21 Sep 2009 21:44:23 +0000 [thread overview]
Message-ID: <20090921144423.6ebf564f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090909093435.60531d95@hyperion.delvare>
On Wed, 9 Sep 2009 09:34:35 +0200
Jean Delvare <khali@linux-fr.org> wrote:
> > #define set_temp_para(name, reg)\
> > static ssize_t set_##name(\
> > struct device *dev,\
> > struct device_attribute *attr,\
> > const char *buf,\
> > size_t count)\
> > {\
> > return set_helper(dev, attr, buf, count, &dev->name);\
> > }
> >
> > And then do all the real work in a common function? Rather than
> > expanding tens of copies of the same thing?
>
> Yes please. We got rid of macro-generated callbacks in most hwmon
> drivers a couple years ago already.
I never received an update to this patch so I'm retaining it in my tree
for now.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: tomaz.mertelj@guest.arnes.si, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip
Date: Mon, 21 Sep 2009 14:44:23 -0700 [thread overview]
Message-ID: <20090921144423.6ebf564f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090909093435.60531d95@hyperion.delvare>
On Wed, 9 Sep 2009 09:34:35 +0200
Jean Delvare <khali@linux-fr.org> wrote:
> > #define set_temp_para(name, reg)\
> > static ssize_t set_##name(\
> > struct device *dev,\
> > struct device_attribute *attr,\
> > const char *buf,\
> > size_t count)\
> > {\
> > return set_helper(dev, attr, buf, count, &dev->name);\
> > }
> >
> > And then do all the real work in a common function? Rather than
> > expanding tens of copies of the same thing?
>
> Yes please. We got rid of macro-generated callbacks in most hwmon
> drivers a couple years ago already.
I never received an update to this patch so I'm retaining it in my tree
for now.
next prev parent reply other threads:[~2009-09-21 21:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 20:24 [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 tomaz.mertelj
2009-08-31 20:24 ` [PATCH] hwmon: Driver for Texas Instruments amc6821 chip tomaz.mertelj
2009-09-01 17:56 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Andre Prendel
2009-09-01 17:56 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip Andre Prendel
2009-09-02 8:20 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments Tomaz Mertelj
2009-09-02 8:20 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip Tomaz Mertelj
2009-09-02 8:45 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments corentin.labbe
2009-09-02 8:45 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip corentin.labbe
2009-09-02 23:55 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments Andrew Morton
2009-09-02 23:55 ` [PATCH] hwmon: Driver for Texas Instruments amc6821 chip Andrew Morton
2009-09-05 12:08 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments tomaz.mertelj
2009-09-05 12:08 ` [PATCH] hwmon: Driver for Texas Instruments amc6821 chip tomaz.mertelj
2009-09-09 0:06 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments Andrew Morton
2009-09-09 0:06 ` [PATCH] hwmon: Driver for Texas Instruments amc6821 chip Andrew Morton
2009-09-09 7:34 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments Jean Delvare
2009-09-09 7:34 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip Jean Delvare
2009-09-09 8:06 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments Andrew Morton
2009-09-09 8:06 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip Andrew Morton
2009-09-09 12:24 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments Tomaz Mertelj
2009-09-09 12:24 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip Tomaz Mertelj
2009-09-09 12:45 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments Jean Delvare
2009-09-09 12:45 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip Jean Delvare
2009-09-21 21:44 ` Andrew Morton [this message]
2009-09-21 21:44 ` Andrew Morton
2009-09-22 5:59 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments Tomaz Mertelj
2009-09-22 5:59 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip Tomaz Mertelj
2009-09-22 6:02 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments Andrew Morton
2009-09-22 6:02 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip Andrew Morton
2013-01-13 0:16 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments INA209 Guenter Roeck
2013-01-14 21:17 ` Ira W. Snyder
2013-01-15 6:04 ` Guenter Roeck
2013-01-15 22:10 ` Paul Hays
2013-01-15 22:56 ` Guenter Roeck
2013-01-22 21:43 ` Ira W. Snyder
2013-01-22 22:15 ` Ira W. Snyder
2013-01-23 4:30 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2009-09-23 9:32 [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip tomaz.mertelj
2009-09-30 19:44 ` [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090921144423.6ebf564f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=tomaz.mertelj@guest.arnes.si \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.