All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	Alasdair G Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] block: Add blk_queue_copy_limits()
Date: Mon, 21 Sep 2009 21:45:18 +0200	[thread overview]
Message-ID: <20090921194518.GJ23126@kernel.dk> (raw)
In-Reply-To: <yq1iqfc3wyw.fsf@sermon.lab.mkp.net>

On Mon, Sep 21 2009, Martin K. Petersen wrote:
> >>>>> "Jun'ichi" == Jun'ichi Nomura <j-nomura@ce.jp.nec.com> writes:
> 
> Jun'ichi> If we aren't sure, shouldn't we set its default to -1 or
> Jun'ichi> putting comments in blk_set_default_limits() at least to avoid
> Jun'ichi> possible confusion in future?
> 
> Jens, what do you think about this?  Goes on top of what you have
> queued...

Look sane, applied.

-- 
Jens Axboe

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jens.axboe@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	Alasdair G Kergon <agk@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 1/3] block: Add blk_queue_copy_limits()
Date: Mon, 21 Sep 2009 21:45:18 +0200	[thread overview]
Message-ID: <20090921194518.GJ23126@kernel.dk> (raw)
In-Reply-To: <yq1iqfc3wyw.fsf@sermon.lab.mkp.net>

On Mon, Sep 21 2009, Martin K. Petersen wrote:
> >>>>> "Jun'ichi" == Jun'ichi Nomura <j-nomura@ce.jp.nec.com> writes:
> 
> Jun'ichi> If we aren't sure, shouldn't we set its default to -1 or
> Jun'ichi> putting comments in blk_set_default_limits() at least to avoid
> Jun'ichi> possible confusion in future?
> 
> Jens, what do you think about this?  Goes on top of what you have
> queued...

Look sane, applied.

-- 
Jens Axboe


  reply	other threads:[~2009-09-21 19:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 16:24 [PATCH 1/3] block: Add blk_queue_copy_limits() Jun'ichi Nomura
2009-09-18 16:24 ` Jun'ichi Nomura
2009-09-18 16:26 ` [PATCH 2/3] dm: Use blk_queue_copy_limits() Jun'ichi Nomura
2009-09-18 16:26   ` Jun'ichi Nomura
2009-09-18 19:11   ` Mike Snitzer
2009-09-18 19:11     ` Mike Snitzer
2009-09-18 16:29 ` [PATCH 3/3] block: blk_set_default_limits sets 0 to max_sectors Jun'ichi Nomura
2009-09-18 16:29   ` Jun'ichi Nomura
2009-09-18 19:07 ` [PATCH 1/3] block: Add blk_queue_copy_limits() Mike Snitzer
2009-09-18 19:07   ` Mike Snitzer
2009-09-18 19:28 ` Martin K. Petersen
2009-09-18 19:28   ` [dm-devel] " Martin K. Petersen
2009-09-18 20:30   ` Mike Snitzer
2009-09-18 20:30     ` Mike Snitzer
2009-09-19 15:22   ` Jun'ichi Nomura
2009-09-19 15:22     ` [dm-devel] " Jun'ichi Nomura
2009-09-20 21:00     ` Martin K. Petersen
2009-09-20 21:00       ` [dm-devel] " Martin K. Petersen
2009-09-21 16:33       ` Jun'ichi Nomura
2009-09-21 16:33         ` [dm-devel] " Jun'ichi Nomura
2009-09-21 19:43         ` Martin K. Petersen
2009-09-21 19:43           ` [dm-devel] " Martin K. Petersen
2009-09-21 19:45           ` Jens Axboe [this message]
2009-09-21 19:45             ` Jens Axboe
2009-09-18 20:33 ` Jens Axboe
2009-09-18 20:33   ` Jens Axboe
2009-09-18 20:35   ` Jens Axboe
2009-09-18 20:35     ` Jens Axboe
2009-09-19 15:35     ` Jun'ichi Nomura
2009-09-19 15:35       ` Jun'ichi Nomura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090921194518.GJ23126@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.