From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org, linux-mm@kvack.org, npiggin@suse.de,
tytso@mit.edu
Subject: Re: [PATCH 5/7] ext4: Convert filesystem to the new truncate calling convention
Date: Tue, 22 Sep 2009 18:23:47 +0100 [thread overview]
Message-ID: <20090922172347.GG14381@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090922171604.GA31447@duck.suse.cz>
On Tue, Sep 22, 2009 at 07:16:04PM +0200, Jan Kara wrote:
> > No. We already have one half-finished series here; mixing it with another
> > one is not going to happen. Such flags are tolerable only as bisectability
> > helpers. They *must* disappear by the end of series. Before it can be
> > submitted for merge.
> >
> > In effect, you are mixing truncate switchover with your writepage one.
> > Please, split and reorder.
> Well, this wasn't meant as a final version of those patches. It was
> meant as a request for comment whether it makes sence to fix the problem
> how I propose to fix it. If we agree on that, I'll go and convert the rest
> of filesystems so that we can remove .new_writepage hack. By that time I
> hope that new truncate sequence patches will be merged so that dependency
> should go away as well...
Could you carve just the ext4 part of truncate series out of that and
post it separately?
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org, linux-mm@kvack.org, npiggin@suse.de,
tytso@mit.edu
Subject: Re: [PATCH 5/7] ext4: Convert filesystem to the new truncate calling convention
Date: Tue, 22 Sep 2009 18:23:47 +0100 [thread overview]
Message-ID: <20090922172347.GG14381@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090922171604.GA31447@duck.suse.cz>
On Tue, Sep 22, 2009 at 07:16:04PM +0200, Jan Kara wrote:
> > No. We already have one half-finished series here; mixing it with another
> > one is not going to happen. Such flags are tolerable only as bisectability
> > helpers. They *must* disappear by the end of series. Before it can be
> > submitted for merge.
> >
> > In effect, you are mixing truncate switchover with your writepage one.
> > Please, split and reorder.
> Well, this wasn't meant as a final version of those patches. It was
> meant as a request for comment whether it makes sence to fix the problem
> how I propose to fix it. If we agree on that, I'll go and convert the rest
> of filesystems so that we can remove .new_writepage hack. By that time I
> hope that new truncate sequence patches will be merged so that dependency
> should go away as well...
Could you carve just the ext4 part of truncate series out of that and
post it separately?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-09-22 17:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 15:21 [RFC] [PATCH 0/7] Improve VFS to handle better mmaps when blocksize < pagesize (v3) Jan Kara
2009-09-17 15:21 ` Jan Kara
2009-09-17 15:21 ` [PATCH 1/7] fs: buffer_head writepage no invalidate Jan Kara
2009-09-17 15:21 ` Jan Kara
2009-09-17 15:21 ` [PATCH 2/7] fs: Remove zeroing from nobh_writepage Jan Kara
2009-09-17 15:21 ` Jan Kara
2009-09-17 15:21 ` [PATCH 3/7] ext4: Deprecate nobh mount option Jan Kara
2009-09-17 15:21 ` Jan Kara
2009-09-17 15:21 ` [PATCH 4/7] vfs: Add better VFS support for page_mkwrite when blocksize < pagesize Jan Kara
2009-09-17 15:21 ` Jan Kara
2009-09-17 15:21 ` [PATCH 5/7] ext4: Convert filesystem to the new truncate calling convention Jan Kara
2009-09-17 15:21 ` Jan Kara
2009-09-22 14:36 ` Al Viro
2009-09-22 14:36 ` Al Viro
2009-09-22 17:16 ` Jan Kara
2009-09-22 17:16 ` Jan Kara
2009-09-22 17:23 ` Al Viro [this message]
2009-09-22 17:23 ` Al Viro
2009-09-22 17:37 ` Jan Kara
2009-09-22 17:37 ` Jan Kara
2009-09-17 15:21 ` [PATCH 6/7] ext4: Convert ext4 to new mkwrite code Jan Kara
2009-09-17 15:21 ` Jan Kara
2009-09-17 15:21 ` [PATCH 7/7] ext2: Convert ext2 " Jan Kara
2009-09-17 15:21 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2009-09-22 17:42 [PATCH 5/7] ext4: Convert filesystem to the new truncate calling convention Jan Kara
2009-09-22 17:42 ` Jan Kara
2009-09-22 17:48 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090922172347.GG14381@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.