Patch for 2.6.31-rc9

Patch for 2.6.31-rc9

[Andy Georges]

Hi,


When building the 2.6.31-rc9 kernel with xen patches, obtained as per  
the instructions on http://wiki.xensource.com/xenwiki/XenParavirtOps,  
i.e.,

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/ 
xen.git linux-2.6-xen
$ cd linux-2.6-xen
$ git checkout origin/xen/master -b xen/master
$ git pull
$ make menuconfig

I ran into the following error:

root@assail:/usr/src/linux-2.6-xen# make -j 12 modules
   CHK     include/linux/version.h
   CHK     include/linux/utsrelease.h
   SYMLINK include/asm -> include/asm-x86
   CALL    scripts/checksyscalls.sh
   CC [M]  drivers/gpu/drm/ttm/ttm_agp_backend.o
   CC [M]  drivers/gpu/drm/via/via_irq.o
   CC [M]  drivers/gpu/drm/ttm/ttm_memory.o
   CC [M]  drivers/gpu/drm/via/via_drv.o
In file included from /usr/src/linux-2.6-xen/arch/x86/include/asm/ 
agp.h:4,
                  from drivers/gpu/drm/ttm/ttm_agp_backend.c:39:
include/linux/swiotlb.h:48: warning: ‘enum dma_data_direction’  
declared inside parameter list
include/linux/swiotlb.h:48: warning: its scope is only this definition  
or declaration, which is probably not what you want
include/linux/swiotlb.h:51: warning: ‘enum dma_data_direction’  
declared inside parameter list
include/linux/swiotlb.h:63: warning: ‘enum dma_data_direction’  
declared inside parameter list
include/linux/swiotlb.h:68: warning: ‘enum dma_data_direction’  
declared inside parameter list
include/linux/swiotlb.h:72: warning: ‘enum dma_data_direction’  
declared inside parameter list
include/linux/swiotlb.h:76: warning: ‘enum dma_data_direction’  
declared inside parameter list
include/linux/swiotlb.h:80: warning: ‘enum dma_data_direction’  
declared inside parameter list
include/linux/swiotlb.h:84: warning: ‘enum dma_data_direction’  
declared inside parameter list
include/linux/swiotlb.h:89: warning: ‘enum dma_data_direction’  
declared inside parameter list
include/linux/swiotlb.h:94: warning: ‘enum dma_data_direction’  
declared inside parameter list
In file included from /usr/src/linux-2.6-xen/arch/x86/include/asm/ 
agp.h:8,
                  from drivers/gpu/drm/ttm/ttm_agp_backend.c:39:
/usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h: In function  
‘get_dma_ops’:
/usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h:29: error:  
dereferencing pointer to incomplete type
/usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h:32: error:  
dereferencing pointer to incomplete type
In file included from /usr/src/linux-2.6-xen/arch/x86/include/asm/dma- 
mapping.h:36,
                  from /usr/src/linux-2.6-xen/arch/x86/include/asm/ 
agp.h:8,
                  from drivers/gpu/drm/ttm/ttm_agp_backend.c:39:
<snip>

The last change to the kernel was:

commit 3973dcf8835207714f10ce4847fa57e9f35b8197
Merge: ebf47a1 7676973
Author: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Date:   Thu Sep 17 12:47:49 2009 -0700

     Merge commit 'xen/xen/xenfb' into xen/master

     * commit 'xen/xen/xenfb':
       xenfb: connect to backend before registering fb


The above issue can be resolved by the following patch:

diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index cb1a663..f4ebffb 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -2,6 +2,7 @@
  #define __LINUX_SWIOTLB_H

  #include <linux/types.h>
+#include <linux/dma-mapping.h>

  struct device;
  struct dma_attrs;

I did get the patch from the Fedora list, after googling, so maybe  
somebody already has it lined up for inclusion (http://www.mail-archive.com/fedora-xen@redhat.com/msg02913.html 
)?

Hope this helps,
-- Andy

Re: Patch for 2.6.31-rc9

[Boris Derzhavets]

[-- Attachment #1.1: Type: text/plain, Size: 4495 bytes --]

This seems a kind of mystery for me. Message from Jeremy (@xen-devel) , suggesting to add "# <linux/dma-mapping.h>"  to file "include/linux/swiotlb.h"  was made about 2-3 weeks ago. Since then kernel's git repo got a lot of commits, moved to 2.6.31. Swiotlb issue was tracked down and fixed by Konrad and etc.
However, include/linux/swiotlb.h stays the same.

Boris.

--- On Tue, 9/22/09, Andy Georges <andy.georges@elis.ugent.be> wrote:

From: Andy Georges <andy.georges@elis.ugent.be>
Subject: [Xen-devel] Patch for 2.6.31-rc9
To: xen-devel@lists.xensource.com
Date: Tuesday, September 22, 2009, 10:55 AM

Hi,


When building the 2.6.31-rc9 kernel with xen patches, obtained as per the instructions on http://wiki.xensource.com/xenwiki/XenParavirtOps, i.e.,

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git linux-2.6-xen
$ cd linux-2.6-xen
$ git checkout origin/xen/master -b xen/master
$ git pull
$ make menuconfig

I ran into the following error:

root@assail:/usr/src/linux-2.6-xen# make -j 12 modules
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  SYMLINK include/asm -> include/asm-x86
  CALL    scripts/checksyscalls.sh
  CC [M]  drivers/gpu/drm/ttm/ttm_agp_backend.o
  CC [M]  drivers/gpu/drm/via/via_irq.o
  CC [M]  drivers/gpu/drm/ttm/ttm_memory.o
  CC [M]  drivers/gpu/drm/via/via_drv.o
In file included from /usr/src/linux-2.6-xen/arch/x86/include/asm/agp.h:4,
                 from drivers/gpu/drm/ttm/ttm_agp_backend.c:39:
include/linux/swiotlb.h:48: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:48: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/swiotlb.h:51: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:63: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:68: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:72: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:76: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:80: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:84: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:89: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:94: warning: ‘enum dma_data_direction’ declared inside parameter list
In file included from /usr/src/linux-2.6-xen/arch/x86/include/asm/agp.h:8,
                 from drivers/gpu/drm/ttm/ttm_agp_backend.c:39:
/usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h: In function ‘get_dma_ops’:
/usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h:29: error: dereferencing pointer to incomplete type
/usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h:32: error: dereferencing pointer to incomplete type
In file included from /usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h:36,
                 from /usr/src/linux-2.6-xen/arch/x86/include/asm/agp.h:8,
                 from drivers/gpu/drm/ttm/ttm_agp_backend.c:39:
<snip>

The last change to the kernel was:

commit 3973dcf8835207714f10ce4847fa57e9f35b8197
Merge: ebf47a1 7676973
Author: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Date:   Thu Sep 17 12:47:49 2009 -0700

    Merge commit 'xen/xen/xenfb' into xen/master

    * commit 'xen/xen/xenfb':
      xenfb: connect to backend before registering fb


The above issue can be resolved by the following patch:

diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index cb1a663..f4ebffb 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -2,6 +2,7 @@
 #define __LINUX_SWIOTLB_H

 #include <linux/types.h>
+#include <linux/dma-mapping.h>

 struct device;
 struct dma_attrs;

I did get the patch from the Fedora list, after googling, so maybe somebody already has it lined up for inclusion (http://www.mail-archive.com/fedora-xen@redhat.com/msg02913.html)?

Hope this helps,
-- Andy



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

[-- Attachment #1.2: Type: text/html, Size: 5761 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: Patch for 2.6.31-rc9

[Jeremy Fitzhardinge]

On 09/22/09 08:14, Boris Derzhavets wrote:
> This seems a kind of mystery for me. Message from Jeremy (@xen-devel)
> , suggesting to add "# <linux/dma-mapping.h>"  to file
> "include/linux/swiotlb.h"  was made about 2-3 weeks ago. Since then
> kernel's git repo got a lot of commits, moved to 2.6.31. Swiotlb issue
> was tracked down and fixed by Konrad and etc.
> However, include/linux/swiotlb.h stays the same.
>

Sorry about that.  I have been meaning to ask for a .config which shows
this compile problem so I can verify the fix (I want to check what
combination of CONFIG_ options causes/avoids the problem).

Thanks,
    J

Re: Patch for 2.6.31-rc9

[Konrad Rzeszutek Wilk]

On Tue, Sep 22, 2009 at 10:35:30AM -0700, Jeremy Fitzhardinge wrote:
> On 09/22/09 08:14, Boris Derzhavets wrote:
> > This seems a kind of mystery for me. Message from Jeremy (@xen-devel)
> > , suggesting to add "# <linux/dma-mapping.h>"  to file
> > "include/linux/swiotlb.h"  was made about 2-3 weeks ago. Since then
> > kernel's git repo got a lot of commits, moved to 2.6.31. Swiotlb issue
> > was tracked down and fixed by Konrad and etc.
> > However, include/linux/swiotlb.h stays the same.
> >
> 
> Sorry about that.  I have been meaning to ask for a .config which shows
> this compile problem so I can verify the fix (I want to check what
> combination of CONFIG_ options causes/avoids the problem).

CONFIG_DRM=y
CONFIG_DRM_TTM=m

> 
> Thanks,
>     J
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: Patch for 2.6.31-rc9

[Jeremy Fitzhardinge]

On 09/22/09 12:24, Konrad Rzeszutek Wilk wrote:
> CONFIG_DRM=y
> CONFIG_DRM_TTM=m
>   

Ah, and TTM requires KMS_RADEON to be set.

    J

Re: Patch for 2.6.31-rc9

[Boris Derzhavets]

[-- Attachment #1.1: Type: text/plain, Size: 1183 bytes --]

Having all parameters set as suggested, i still must have second "#include"
in "include/linux/swiotlb.h" to build the kernel.

  I've also replaced GeForce 8500 GT by Radeon HD 4650.
It helps on on F11&F12 to login into Gnome Desktop with no trouble.
(Xen 3.4.1 Dom0 with 2.6.31)
However, on Ubuntu 9.04 Server ( with Ubuntu Desktop installed via tasksel)
login GDM screen appears to be frozen. Mouse cursor seems strange and
doesn't work at all.  (Xen 3.5 Dom0 with 2.6.31)

Boris.

--- On Tue, 9/22/09, Jeremy Fitzhardinge <jeremy@goop.org> wrote:

From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [Xen-devel] Patch for 2.6.31-rc9
To: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Cc: "Boris Derzhavets" <bderzhavets@yahoo.com>, xen-devel@lists.xensource.com, "Andy Georges" <andy.georges@elis.ugent.be>
Date: Tuesday, September 22, 2009, 6:14 PM

On 09/22/09 12:24, Konrad Rzeszutek Wilk wrote:
> CONFIG_DRM=y
> CONFIG_DRM_TTM=m
>   

Ah, and TTM requires KMS_RADEON to be set.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

[-- Attachment #1.2: Type: text/html, Size: 1775 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: Patch for 2.6.31-rc9

[Jeremy Fitzhardinge]

On 09/22/09 21:46, Boris Derzhavets wrote:
> Having all parameters set as suggested, i still must have second
> "#include"
> in "include/linux/swiotlb.h" to build the kernel.
>

No my comment was just a further elaboration of what's required to hit
the build problem.  I've added the include and pushed it.  Does it fix
the problem for you?

Thanks,
    J

Re: Patch for 2.6.31-rc9

[Boris Derzhavets]

[-- Attachment #1.1: Type: text/plain, Size: 1007 bytes --]

Yes. I've already made a build with new version include/linux/swiotlb.h.

 Thanks.
 Boris

--- On Wed, 9/23/09, Jeremy Fitzhardinge <jeremy@goop.org> wrote:

From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [Xen-devel] Patch for 2.6.31-rc9
To: "Boris Derzhavets" <bderzhavets@yahoo.com>
Cc: xen-devel@lists.xensource.com, "Andy Georges" <andy.georges@elis.ugent.be>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Date: Wednesday, September 23, 2009, 3:05 PM

On 09/22/09 21:46, Boris Derzhavets wrote:
> Having all parameters set as suggested, i still must have second
> "#include"
> in "include/linux/swiotlb.h" to build the kernel.
>

No my comment was just a further elaboration of what's required to hit
the build problem.  I've added the include and pushed it.  Does it fix
the problem for you?

Thanks,
    J

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

[-- Attachment #1.2: Type: text/html, Size: 1587 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel