All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: patch to replace (UUID=) hack
Date: Thu, 24 Sep 2009 14:02:19 +0200	[thread overview]
Message-ID: <20090924120219.GA4558@thorin> (raw)
In-Reply-To: <4AB88317.1070603@gmail.com>

On Tue, Sep 22, 2009 at 09:56:07AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Try attached WIP patch

Excellent.  This was quite necessary.  I have to admit my (UUID=) kludge was
a really poor solution (although in that time, the alternatives weren't
so straightforwarded).

I'm inclined to allow this for inclusion in 1.97, since it fixes a problem
that could be seen as a bug (the overhead can be huge, specially in slow
setups).

> -        prefix_drive="(UUID=${uuid})"
> -        modules="$modules fs_uuid"
> +        config="search_fs_uuid ${uuid} root"
> +        modules="$modules search_fs_uuid"

Note we don't need to explicitly include "root" there.  This would save 5
bytes, and make the behaviour a bit more consistent (since root is
implicit afterwards).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



  reply	other threads:[~2009-09-24 12:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4ab7a42f.8353f10a.25a9.4896SMTPIN_ADDED@mx.google.com>
2009-09-22  3:17 ` Current Grub2 & problem with /boot on different drive Dean Loros
2009-09-22  7:56   ` Vladimir 'phcoder' Serbinenko
2009-09-24 12:02     ` Robert Millan [this message]
2009-09-25 11:31       ` patch to replace (UUID=) hack Vladimir 'phcoder' Serbinenko
2009-09-25 14:14         ` Robert Millan
2009-09-25 14:32           ` Vladimir 'phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090924120219.GA4558@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.