From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: Solving section mismatches
Date: Sun, 27 Sep 2009 19:39:04 +0100 [thread overview]
Message-ID: <20090927183904.GD20093@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090927182707.GA10405@merkur.ravnborg.org>
On Sun, Sep 27, 2009 at 08:27:07PM +0200, Sam Ravnborg wrote:
> On Sun, Sep 27, 2009 at 05:41:16PM +0100, Russell King - ARM Linux wrote:
> > Sam,
> >
> > Any idea how to solve this:
> >
> > WARNING: arch/arm/kernel/built-in.o(.text+0x1ebc): Section mismatch in reference from the function cpu_idle() to the function .cpuexit.text:cpu_die()
> > The function cpu_idle() references a function in an exit section.
> > Often the function cpu_die() has valid usage outside the exit section
> > and the fix is to remove the __cpuexit annotation of cpu_die.
> >
> > WARNING: arch/arm/kernel/built-in.o(.cpuexit.text+0x3c): Section mismatch in reference from the function cpu_die() to the function .cpuinit.text:secondary_start_kernel()
> > The function __cpuexit cpu_die() references
> > a function __cpuinit secondary_start_kernel().
> > This is often seen when error handling in the exit function
> > uses functionality in the init path.
> > The fix is often to remove the __cpuinit annotation of
> > secondary_start_kernel() so it may be used outside an init section.
> >
> > Logically, the annotations are correct - in the first case, cpu_die()
> > will only ever be called if hotplug CPU is enabled, since you can't
> > offline a CPU without hotplug CPU enabled. In that case, the __cpuexit.*
> > sections are not discarded.
>
> The annotation of cpu_die() is wrong.
> To be annotated __cpuexit the function shall:
> - be used in exit context and only in exit context with HOTPLUG_CPU=n
> - be used outside exit context with HOTPLUG_CPU=y
>
> cpu_die() fails on the first condition because it is only used
> if HOTPLUG_CPU=y.
> The annotation is wrongly used as a replacement for an ifdef.
> As cpu_die() is already inside ifdef CONFIG_HOTPLUG_CPU is should
> be enough to just remove the annotation.
>
> Like this (copy'n'paste so it does not apply)
>
> diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> index e0d3277..de4ef1c 100644
> --- a/arch/arm/kernel/smp.c
> +++ b/arch/arm/kernel/smp.c
> @@ -214,7 +214,7 @@ void __cpuexit __cpu_die(unsigned int cpu)
> * of the other hotplug-cpu capable cores, so presumably coming
> * out of idle fixes this.
> */
> -void __cpuexit cpu_die(void)
> +void cpu_die(void)
> {
> unsigned int cpu = smp_processor_id();
This is wrong. cpu_die() does not need to exist if hotplug CPU is
disabled. In that case, it should be discarded and this is precisely
what __cpuexit does. The annotation is, therefore, correct.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: Solving section mismatches
Date: Sun, 27 Sep 2009 19:39:04 +0100 [thread overview]
Message-ID: <20090927183904.GD20093@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090927182707.GA10405@merkur.ravnborg.org>
On Sun, Sep 27, 2009 at 08:27:07PM +0200, Sam Ravnborg wrote:
> On Sun, Sep 27, 2009 at 05:41:16PM +0100, Russell King - ARM Linux wrote:
> > Sam,
> >
> > Any idea how to solve this:
> >
> > WARNING: arch/arm/kernel/built-in.o(.text+0x1ebc): Section mismatch in reference from the function cpu_idle() to the function .cpuexit.text:cpu_die()
> > The function cpu_idle() references a function in an exit section.
> > Often the function cpu_die() has valid usage outside the exit section
> > and the fix is to remove the __cpuexit annotation of cpu_die.
> >
> > WARNING: arch/arm/kernel/built-in.o(.cpuexit.text+0x3c): Section mismatch in reference from the function cpu_die() to the function .cpuinit.text:secondary_start_kernel()
> > The function __cpuexit cpu_die() references
> > a function __cpuinit secondary_start_kernel().
> > This is often seen when error handling in the exit function
> > uses functionality in the init path.
> > The fix is often to remove the __cpuinit annotation of
> > secondary_start_kernel() so it may be used outside an init section.
> >
> > Logically, the annotations are correct - in the first case, cpu_die()
> > will only ever be called if hotplug CPU is enabled, since you can't
> > offline a CPU without hotplug CPU enabled. In that case, the __cpuexit.*
> > sections are not discarded.
>
> The annotation of cpu_die() is wrong.
> To be annotated __cpuexit the function shall:
> - be used in exit context and only in exit context with HOTPLUG_CPU=n
> - be used outside exit context with HOTPLUG_CPU=y
>
> cpu_die() fails on the first condition because it is only used
> if HOTPLUG_CPU=y.
> The annotation is wrongly used as a replacement for an ifdef.
> As cpu_die() is already inside ifdef CONFIG_HOTPLUG_CPU is should
> be enough to just remove the annotation.
>
> Like this (copy'n'paste so it does not apply)
>
> diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> index e0d3277..de4ef1c 100644
> --- a/arch/arm/kernel/smp.c
> +++ b/arch/arm/kernel/smp.c
> @@ -214,7 +214,7 @@ void __cpuexit __cpu_die(unsigned int cpu)
> * of the other hotplug-cpu capable cores, so presumably coming
> * out of idle fixes this.
> */
> -void __cpuexit cpu_die(void)
> +void cpu_die(void)
> {
> unsigned int cpu = smp_processor_id();
This is wrong. cpu_die() does not need to exist if hotplug CPU is
disabled. In that case, it should be discarded and this is precisely
what __cpuexit does. The annotation is, therefore, correct.
next prev parent reply other threads:[~2009-09-27 18:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-27 16:41 Solving section mismatches Russell King - ARM Linux
2009-09-27 16:41 ` Russell King - ARM Linux
2009-09-27 18:27 ` Sam Ravnborg
2009-09-27 18:27 ` Sam Ravnborg
2009-09-27 18:39 ` Russell King - ARM Linux [this message]
2009-09-27 18:39 ` Russell King - ARM Linux
2009-09-27 18:46 ` Sam Ravnborg
2009-09-27 18:46 ` Sam Ravnborg
2009-09-27 19:09 ` Russell King - ARM Linux
2009-09-27 19:09 ` Russell King - ARM Linux
2009-09-27 19:47 ` Sam Ravnborg
2009-09-27 19:47 ` Sam Ravnborg
2009-09-27 20:15 ` Russell King - ARM Linux
2009-09-27 20:15 ` Russell King - ARM Linux
2009-09-27 20:22 ` Sam Ravnborg
2009-09-27 20:22 ` Sam Ravnborg
2009-09-27 20:24 ` Russell King - ARM Linux
2009-09-27 20:24 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090927183904.GD20093@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.