All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: Robert Hancock <hancockrwd@gmail.com>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] asus_atk0110: add support for Asus P7P55D
Date: Mon, 28 Sep 2009 13:22:10 +0000	[thread overview]
Message-ID: <20090928152210.593e5d48@hyperion.delvare> (raw)
In-Reply-To: <20090928131700.GA19243@nb-core2.darkstar.lan>

Hi Lucas,

On Mon, 28 Sep 2009 15:17:00 +0200, Luca Tettamanti wrote:
> I have a new patch for you :)
> It contains the previous changes to handle the bigger ASBF buffer plus a new
> method to enable the EC as suggested by Asus. Be sure to compile with
> HWMON_DEBUG_CHIP enabled.

Wow, that's a lot of code to just enable the EC, I hoped it would be
more simple than this :(

Wouldn't it make sense to also disable the EC when the asus_atk0110
driver is removed? To restore the chip to its initial state.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: Robert Hancock <hancockrwd@gmail.com>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] asus_atk0110: add support for Asus P7P55D
Date: Mon, 28 Sep 2009 15:22:10 +0200	[thread overview]
Message-ID: <20090928152210.593e5d48@hyperion.delvare> (raw)
In-Reply-To: <20090928131700.GA19243@nb-core2.darkstar.lan>

Hi Lucas,

On Mon, 28 Sep 2009 15:17:00 +0200, Luca Tettamanti wrote:
> I have a new patch for you :)
> It contains the previous changes to handle the bigger ASBF buffer plus a new
> method to enable the EC as suggested by Asus. Be sure to compile with
> HWMON_DEBUG_CHIP enabled.

Wow, that's a lot of code to just enable the EC, I hoped it would be
more simple than this :(

Wouldn't it make sense to also disable the EC when the asus_atk0110
driver is removed? To restore the chip to its initial state.

-- 
Jean Delvare

  reply	other threads:[~2009-09-28 13:22 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23 19:12 [PATCH] asus_atk0110: add support for Asus P7P55D Luca Tettamanti
2009-09-24  3:18 ` Robert Hancock
2009-09-24  8:53   ` [lm-sensors] " Luca Tettamanti
2009-09-24  8:53     ` Luca Tettamanti
2009-09-28 13:17   ` [lm-sensors] " Luca Tettamanti
2009-09-28 13:17     ` Luca Tettamanti
2009-09-28 13:22     ` Jean Delvare [this message]
2009-09-28 13:22       ` Jean Delvare
2009-09-28 13:40       ` [lm-sensors] " Luca Tettamanti
2009-09-28 13:40         ` Luca Tettamanti
2009-09-29  2:20     ` [lm-sensors] " Robert Hancock
2009-09-29  2:20       ` Robert Hancock
2009-09-29  4:34       ` [lm-sensors] " Robert Hancock
2009-09-29  4:34         ` Robert Hancock
2009-09-29 14:07         ` [lm-sensors] " Luca Tettamanti
2009-09-29 14:07           ` Luca Tettamanti
2009-09-29 14:40           ` [lm-sensors] " Robert Hancock
2009-09-29 14:40             ` Robert Hancock
2009-09-29 14:49             ` [lm-sensors] " Thomas Backlund
2009-09-29 14:49               ` Thomas Backlund
2009-09-30  2:08               ` [lm-sensors] " Robert Hancock
2009-09-30  2:08                 ` Robert Hancock
2009-09-30 23:38               ` [lm-sensors] " Robert Hancock
2009-09-30 23:38                 ` Robert Hancock
2009-10-01  6:50                 ` [lm-sensors] " Jean Delvare
2009-10-01  6:50                   ` Jean Delvare
2009-10-01 14:40                   ` [lm-sensors] " Robert Hancock
2009-10-01 14:40                     ` Robert Hancock
2009-10-01 14:49                     ` [lm-sensors] " Luca Tettamanti
2009-10-01 14:49                       ` Luca Tettamanti
2009-10-01 16:21                       ` [lm-sensors] " Thomas Backlund
2009-10-01 16:21                         ` Thomas Backlund
2009-10-01 19:05                         ` [lm-sensors] " Luca Tettamanti
2009-10-01 19:05                           ` Luca Tettamanti
2009-10-02 12:26                           ` [lm-sensors] " Luca Tettamanti
2009-10-02 12:26                             ` Luca Tettamanti
2009-10-02 20:43                             ` [lm-sensors] " Thomas Backlund
2009-10-02 20:43                               ` Thomas Backlund
2009-10-02 20:45                               ` [lm-sensors] " Thomas Backlund
2009-10-02 20:45                                 ` Thomas Backlund
2009-10-05 15:27                               ` [lm-sensors] " Luca Tettamanti
2009-10-05 15:27                                 ` Luca Tettamanti
2009-10-05 17:26                                 ` [lm-sensors] " Thomas Backlund
2009-10-05 17:26                                   ` Thomas Backlund
2009-10-06  1:44                                   ` [lm-sensors] " Robert Hancock
2009-10-06  1:44                                     ` Robert Hancock
2009-10-01 15:02                 ` [lm-sensors] " Thomas Backlund
2009-10-01 15:02                   ` Thomas Backlund
2009-09-29 14:54             ` [lm-sensors] " Luca Tettamanti
2009-09-29 14:54               ` Luca Tettamanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090928152210.593e5d48@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=hancockrwd@gmail.com \
    --cc=kronos.it@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.