Re: [PATCH 1/1 - try2] ASoC: add support for multiple cards/codecs in debugfs

[Peter Ujfalusi <peter.ujfalusi@nokia.com>]

On Thursday 01 October 2009 13:51:07 ext Mark Brown wrote:
> On Thu, Oct 01, 2009 at 10:32:47AM +0300, Peter Ujfalusi wrote:
> > In order to support multiple codecs on the same system in the debugfs
> > the directory hierarchy need to be changed by adding directory per codec
> > under the asoc direcorty:
> >
> > debugfs/asoc/{dev_name(socdev->dev)}-{codec->name}/codec_reg
> 
> I'd rather use dev_name() for the CODEC itself if possible, that is more
> likely to be stable going forward and one of the immediate aims with the
> API refactoring is to remove socdev entirely at runtime.

At this point the codec->dev was NULL, that is why I have used the socdev->dev 
instead.

> 
> That can be done in a followup, though.
> 
> > @@ -126,7 +126,7 @@ static int soc_pcm_apply_symmetry(struct
> > snd_pcm_substream *substream)
> >
> >  	if (codec_dai->symmetric_rates || cpu_dai->symmetric_rates ||
> >  	    machine->symmetric_rates) {
> > -		dev_dbg(card->dev, "Symmetry forces %dHz rate\n",
> > +		dev_dbg(card->dev, "Symmetry forces %dHz rate\n",
> >  			machine->rate);
> >
> >  		ret = snd_pcm_hw_constraint_minmax(substream->runtime,
> 
> but this doesn't seem to accomplish that goal?  I can't actually spot
> the difference either, I'm assuming it's just whitespace?  If so I'll
> apply as-is.

It is my editor, which removed the tailing space from that line, I have 
mentioned it in the intro mail.

> 

-- 
Péter